Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/etc/sysctl.d/trident-core.conf entries not processed #53

Closed
ghost opened this issue Dec 10, 2018 · 2 comments
Closed

/etc/sysctl.d/trident-core.conf entries not processed #53

ghost opened this issue Dec 10, 2018 · 2 comments

Comments

Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@ghost
Copy link

@ghost ghost commented Dec 10, 2018

sysctl entries in /etc/sysctl.d/trident-core.conf are not processed during startup.

currently not working on 18.11-PRERELEASE_2

steps to reproduce:

  1. to see just the requested sysctls in that file:
cd /etc/sysctl.d
cat trident-core.conf | grep -v "^#" | sort -u | awk '{print $1}'
  1. to see the actual values on a running system:
cd /etc/sysctl.d
for i in `cat trident-core.conf | grep -v "^#" | sort -u | awk -F '=' '{print $1}'`
do
sysctl $i
done
@ghost
Copy link
Author

@ghost ghost commented Dec 10, 2018

ok, in /etc/init.d/sysctl, in function BSD_sysctl(), the line at the top of the function

[ -e /etc/sysctl.conf ] || return 0

says, if /etc/sysctl.conf does not exist, return zero and do not process the rest of the file, meaning do not process any /etc/sysctl.d/*.conf entries.

this is an openrc dev issue, but can be patched, by just adding an empty /etc/sysctl.conf during overlay time.

i'll update the ticket with this detail

@beanpole135
Copy link
Member

@beanpole135 beanpole135 commented Jan 2, 2019

Trident has that file existance check already hot-patched for future checks on bootup:
https://github.com/project-trident/trident-core/blob/master/core-files/usr/local/share/trident/scripts/system-sanity-check.sh

Should be fixed in 18.12-PRERELEASE_2 or later.

@beanpole135 beanpole135 closed this Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment