Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Includes extra file with possible custom firewall rules. #100

Merged
merged 3 commits into from Feb 29, 2020

Conversation

Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@hardcodes
Copy link
Contributor

@hardcodes hardcodes commented Feb 29, 2020

This way users can add their own rules by hand or maybe later with
a gui tool without fearing that their changes will be overwritten
by future updates of the nftable or a TridentOS package.
This extra file must still be included in the installer.

This way users can add their own rules by hand or maybe later with
a gui tool without fearing that their changes will be overwritten
by future updates of the nftable or a TridentOS package.
This extra file must still be included in the installer.
Copy link
Member

@beanpole135 beanpole135 left a comment

The pre-built examples file should also be renamed to custom-input.conf.sample.
Any file listed in this dir will automatically get replaced by the package every time it is installed/updated, so in order to preserve user modifications, it is better to label the package as an example or sample file, and have the user copy it before making changes.

void-files/etc/firewall-conf/open-out.conf Outdated Show resolved Hide resolved
Co-Authored-By: Ken Moore <ken@ixsystems.com>
@hardcodes
Copy link
Contributor Author

@hardcodes hardcodes commented Feb 29, 2020

I have to check if nft still starts if the file is renamed to *.sample

@beanpole135 beanpole135 merged commit 70a9a2f into project-trident:master Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment