Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"PURPOSE not defined" on boot loader #13

Closed
ghost opened this issue Sep 4, 2018 · 4 comments
Closed

"PURPOSE not defined" on boot loader #13

ghost opened this issue Sep 4, 2018 · 4 comments

Comments

Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@ghost
Copy link

@ghost ghost commented Sep 4, 2018

The cause is incorrect formatting of file /boot/logo-trident.4th read by the forth interpreter.
The words PURPOSE, CONSEQUENTIAL, STRICT, and WAY, all part of the standard legal disclaimer, are incorrectly formatted (looks like bad cut and paste) are are interpreted by forth. This causes an error on processing of logo-trident.4th and no trident is displayed.

However, if corrected, a separate problem occurs. The file "logo-trident.4th" is displayed resulting in an overlapping trident on top of the displayed menu (brand-trident.4th), as shown in the attached image.
20180904_171904 2

A horizontal trident is suggested for

@ghost
Copy link
Author

@ghost ghost commented Sep 4, 2018

A horizontal trident is suggested for logo-trident.4th.

@ghost
Copy link
Author

@ghost ghost commented Sep 5, 2018

Here's a sample of a horizontal trident for an artist better than me :-)

logo-trident.4th.txt

File must be installed as /boot/logo-trident.4th to work.

@beanpole135
Copy link
Member

@beanpole135 beanpole135 commented Sep 7, 2018

Thank you for pointing that out!
I just fixed the brand-trident.4th file in this commit: trueos/trueos@f69c785#diff-6883b5ddd892906d6e5a15efeff52ace
and I fixed the logo-trident.4th file for the syntax issues in this commit: trueos/trueos@7d23d5a#diff-6883b5ddd892906d6e5a15efeff52ace

The "logo" will always appear on the right-side of the menu box for the FreeBSD boot menu, so a vertical trident seems to make more sense so that the boot menu can fit on 4:3 aspect ratio screens instead of assuming a 16:9 aspect ratio. The only thing we will still need to test/adjust for the logo file now is probably the placement/scaling of the ascii. I am not terribly familiar with forth, but it seems like we might be able to just adjust line 29 (reproduced below) to move the logo a bit further to the right.

52 logoX ! 9 logoY ! \ Initialize logo placement defaults

@beanpole135
Copy link
Member

@beanpole135 beanpole135 commented Sep 7, 2018

The Trident has now been moved to the right a bit and sligned with the bottom of the menu box.
It also has color too!
trueos/trueos@ec18031

@beanpole135 beanpole135 closed this Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment