Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start-trident-installer doesn't handle wifi names with space in it #66

Closed
Johnnynator opened this issue Nov 8, 2019 · 3 comments
Closed

Comments

Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@Johnnynator
Copy link

@Johnnynator Johnnynator commented Nov 8, 2019

echo -n " $(echo $_line | rev | cut -d ' ' -f 1 | rev) \"$(echo $_line | cut -d ' ' -f 1)\""

You just get the last part of the SSID, so My Network SSID does get shown as SSID.

@beanpole135
Copy link
Member

@beanpole135 beanpole135 commented Nov 8, 2019

Good catch!
Any idea on fixing this? The problem is that the delimiter for that output is whitespace, but If there are multiple line entries with whitespace in them, the parsing gets all funky. Perhaps use the BSSID as the network ID instead?

@Johnnynator
Copy link
Author

@Johnnynator Johnnynator commented Nov 8, 2019

I don't know how stable the format is and if the SSID always starts at after the 5th whitespace. If it does you could just go echo $_line | cut -d ' ' -f 5-

@beanpole135
Copy link
Member

@beanpole135 beanpole135 commented Nov 8, 2019

Committed!
We will have to test this out a bit more to make sure the parsing is reliable long-term, but it is better than what was there initially. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment