Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Security and ZFS Overview subsections to introduction.md #28

Merged
merged 4 commits into from Feb 20, 2019
Merged

Add Security and ZFS Overview subsections to introduction.md #28

merged 4 commits into from Feb 20, 2019

Conversation

Reviewers

@q5sys q5sys

@beanpole135 beanpole135

Assignees

@q5sys q5sys

@Mrt134 Mrt134

Labels
documentation
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@Mrt134 @beanpole135 @q5sys
@Mrt134
Copy link
Collaborator

@Mrt134 Mrt134 commented Feb 14, 2019

Add "Security" subsection
@Mrt134
Update introduction.md
a15631d 
Add "Security" subsection
@Mrt134 Mrt134 requested a review from beanpole135 Feb 14, 2019
@Mrt134 Mrt134 changed the title Update introduction.md Add Security and ZFS Overview subsections to introduction.md Feb 15, 2019
@Mrt134
add ZFS subsection
a2a6864
q5sys
q5sys reviewed Feb 15, 2019
View changes
Copy link
Member

@q5sys q5sys left a comment

Just a few changes to be more specific, and a few grammatical fixes.

@q5sys q5sys removed the request for review from beanpole135 Feb 15, 2019
@Mrt134
Resolve review suggestions
626543d
beanpole135
beanpole135 requested changes Feb 19, 2019
View changes
Copy link
Member

@beanpole135 beanpole135 left a comment

Found a few simple errors. Once those are fixed I think this is ready to be merged.

hugo-site/content/docs/introduction.md Outdated Show resolved Hide resolved
hugo-site/content/docs/introduction.md Outdated Show resolved Hide resolved
hugo-site/content/docs/introduction.md Outdated Show resolved Hide resolved
hugo-site/content/docs/introduction.md Outdated Show resolved Hide resolved
@Mrt134
Update from Ken's review
01cb855
beanpole135
beanpole135 approved these changes Feb 20, 2019
View changes
Copy link
Member

@beanpole135 beanpole135 left a comment

LGTM

@beanpole135 beanpole135 merged commit f1a445e into master Feb 20, 2019
@beanpole135 beanpole135 deleted the Mrt134-patch-3 branch Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment