fixes #1

Merged
merged 2 commits into from May 17, 2016

Projects

None yet

2 participants

@mrRay
Contributor
mrRay commented May 17, 2016

howdy-

this repos required a couple minor changes to get it up and running on my end- please note that i may have done something funky with the cmake stuff, as i am largely unfamiliar with it.

thanks very much for curating this!

specifics:

  • updated build instructions for os x
  • added FindSDL2 cmake module
  • fixed a bug causing a crash with PerlinNoise/ShaderEngine.cpp
  • calling projectM::projectM_resetGL() applies the new dimensions to the window width/height in the settings
  • modified the parser to return an error rather than abort and terminate the process to prevent a crash with the provided sample presets

cheers
: : ray

mrRay added some commits May 17, 2016
@mrRay mrRay updated build config
updated build instructions for os x :: added FindSDL2 cmake module
79a6cba
@mrRay mrRay fixes
fixed a bug causing a crash with PerlinNoise/ShaderEngine.cpp :: calling projectM::projectM_resetGL() applies the new dimensions to the window width/height in the settings :: modified the parser to return an error rather than abort and terminate the process to prevent a crash with the provided sample presets
668f993
@revmischa
Collaborator

Looks great! 👍
I could have sworn it was finding SDL2 just fine without that module, I forget how that was working through.

@revmischa revmischa merged commit 5216c3b into projectM-visualizer:master May 17, 2016
@revmischa revmischa commented on the diff May 17, 2016
src/libprojectM/Renderer/ShaderEngine.cpp
@@ -64,11 +64,11 @@ void ShaderEngine::setParams(const int texsize, const unsigned int texId, const
//std::cout << "Generating Noise Textures" << std::endl;
- PerlinNoise noise;
+ PerlinNoise *noise = new PerlinNoise;
@revmischa
revmischa May 17, 2016 Collaborator

does this need a corresponding delete somewhere?

@mrRay
Contributor
mrRay commented May 18, 2016

oh FFS- yes, nice catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment