Sort input file list #176
Merged
Sort input file list #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that projectM builds in a reproducible way in spite of indeterministic filesystem readdir order. See https://reproducible-builds.org/ for why this is good. Without this patch, multiple .milk files varied between builds in interesting ways: --- "old//usr/share/projectM/presets/Geiss - All-Spark Polar.milk" +++ "new//usr/share/projectM/presets/Geiss - All-Spark Polar.milk" @@ -3,7 +3,7 @@ PSVERSION_WARP=2^M PSVERSION_COMP=2^M [preset00]^M -fRating=4.000000^M +fRating=2.0^M
|
Agreed, there's a semi-related ticket: #109 |
revmischa
pushed a commit
that referenced
this pull request
Nov 16, 2019
so that projectM builds in a reproducible way in spite of indeterministic filesystem readdir order. See https://reproducible-builds.org/ for why this is good. Without this patch, multiple .milk files varied between builds in interesting ways: --- "old//usr/share/projectM/presets/Geiss - All-Spark Polar.milk" +++ "new//usr/share/projectM/presets/Geiss - All-Spark Polar.milk" @@ -3,7 +3,7 @@ PSVERSION_WARP=2^M PSVERSION_COMP=2^M [preset00]^M -fRating=4.000000^M +fRating=2.0^M
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
so that projectM builds in a reproducible way
in spite of indeterministic filesystem readdir order.
See https://reproducible-builds.org/ for why this is good.
Without this patch, multiple .milk files varied between builds
in interesting ways:
Maybe it is also a bug and either duplicate input .milk files should