Permalink
Find file Copy path
Fetching contributors…
Cannot retrieve contributors at this time
94 lines (79 sloc) 4.71 KB

Contributing to Project Ne10

Getting Started

  • Make sure you have a GitHub account.
  • Create an issue for your work if one does not already exist. This gives everyone visibility of whether others are working on something similar. ARM licensees may contact ARM directly via their partner managers instead if they prefer.
    • If you intend to include Third Party IP in your contribution, please raise a separate issue for this and ensure that the changes that include Third Party IP are made on a separate topic branch.
  • Fork Ne10 on GitHub.
  • Clone the fork to your own machine.
  • Create a local topic branch based on the Ne10 master branch.

Making Changes

  • Make commits of logical units. See these general Git guidelines for contributing to a project.
  • Follow the ProjectNe10 coding style; this style is enforced for ProjectNe10.
  • Keep the commits on topic. If you need to fix another bug or make another enhancement, please create a separate issue and address it on a separate topic branch.
  • Avoid long commit series. If you do have a long series, consider whether some commits should be squashed together or addressed in a separate topic.
  • Make sure your commit messages are in the proper format. If a commit fixes a GitHub issue, include a reference (e.g. "fixes projectNe10/Ne10/issues/54"); this ensures the issue is automatically closed when merged into the Ne10 master branch.
  • Where appropriate, please update the documentation.
    • Consider whether the Release Notes or Building file in the Documentation folder need updating.
    • Changes that have a material impact on behavior or programming interfaces should have an entry at the end of the Release Notes. Minor changes (e.g. basic refactoring or typo fixes) do not need an entry.
    • If this is your first contribution, you may add your name or your company name to the Acknowledgements file.
    • For topics with multiple commits, you should make all documentation changes (and nothing else) in the last commit of the series. Otherwise, include the documentation changes within the single commit.
  • Please test your changes. As a minimum, ensure the test application builds and runs. Also, perform unit and conformance tests on new functions.

Submitting Changes

  • Ensure that each commit in the series has at least one Signed-off-by:line, using your real name and email address. The names in the Signed-off-by:andAuthor:lines must match. If anyone else contributes to the commit, they must also add their ownSigned-off-by:` line. By adding this line the contributor certifies the contribution is made under the terms of the Developer Certificate of Origin (DCO).
  • Push your local changes to your fork of the repository.
  • Submit a pull request to Ne10.
    • The changes in the pull request will then undergo further review and testing. Any review comments will be made as comments on the pull request. This may require you to do some rework.
  • When the changes are accepted, ARM will integrate them.
    • To ensure a linear commit history, ARM will typically rebase the commits locally before merging to the Ne10 master branch. In this case, the pull request will be closed rather than directly merged on GitHub. If the rebase is not trivial, you may be asked to rebase the commits yourself.

Copyright (c) 2013-2017, ARM Limited and Contributors. All rights reserved.