Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`#include <math.h>` in inc/*.h files have no reason to be there #212

Closed
giuliomoro opened this issue Nov 8, 2018 · 1 comment
Closed

`#include <math.h>` in inc/*.h files have no reason to be there #212

giuliomoro opened this issue Nov 8, 2018 · 1 comment

Comments

@giuliomoro
Copy link
Contributor

@giuliomoro giuliomoro commented Nov 8, 2018

this actually causes problems if NE10.h is included in a file that then includes <cmath>.
The #include <math.h> line should be in the .c files where appropriate. A number of other includes in NE10.h and a bit all over the place are pointless and should be removed.

@Phillip-Wang
Copy link
Contributor

@Phillip-Wang Phillip-Wang commented Nov 8, 2018

Thank you for contribution. I agree it make no sense to include the headers in the API headers. Could you update your pull request to fix the failures. It is OK to remove the NULL in our macros.
One more thing, please make sure you have commit the change with the Sign-off-by line. Refer to Contributing.md for this requirement.

giuliomoro added a commit to BelaPlatform/Bela that referenced this issue Nov 9, 2018
NE10 is currently stashing lots of unneeded system includes into the main header ( see projectNe10/Ne10#212 ), which may cause incompatibility issues
giuliomoro added a commit to giuliomoro/Ne10 that referenced this issue Nov 14, 2018
Phillip-Wang added a commit that referenced this issue Nov 15, 2018
…#215)

Signed-off-by: Giulio Moro <giuliomoro@yahoo.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants