Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert usages issue in device model from KW work. #3252

Closed
Mingyuan18 opened this issue Jun 12, 2019 · 2 comments
Closed

Assert usages issue in device model from KW work. #3252

Mingyuan18 opened this issue Jun 12, 2019 · 2 comments
Assignees
Labels
priority: P2-High type: bug Something isn't working

Comments

@Mingyuan18
Copy link

Assert usages issue in device model from KW work.

@Mingyuan18
Copy link
Author

[External_System_ID] ACRN-4042

@Mingyuan18 Mingyuan18 added priority: P2-High type: bug Something isn't working labels Jun 12, 2019
YadongQi added a commit to YadongQi/acrn-hypervisor that referenced this issue Jun 13, 2019
Replace assert() with explicit parameter checking and error handling.

Tracked-On: projectacrn#3252
Signed-off-by: Qi Yadong <yadong.qi@intel.com>
Acked-by: Zhu Bing <bing.zhu@intel.com>
acrnsi pushed a commit that referenced this issue Jun 14, 2019
Replace assert() with explicit parameter checking and error handling.

Tracked-On: #3252
Signed-off-by: Qi Yadong <yadong.qi@intel.com>
Acked-by: Zhu Bing <bing.zhu@intel.com>
binbinwu2 pushed a commit to binbinwu2/acrn-hypervisor that referenced this issue Jun 17, 2019
Remove the use of assert() in passthrough driver.

Tracked-On: projectacrn#3252
Signed-off-by: Binbin Wu <binbin.wu@intel.com>
Reviewed-by: Shuo A Liu <shuo.a.liu@intel.com>
ssqre added a commit to acrn-project/acrn-hypervisor that referenced this issue Jun 18, 2019
This patch is to clean up assert from virtio-net.
Tracked-On: projectacrn#3252

Signed-off-by: Jie Deng <jie.deng@intel.com>
Reviewed-by: Shuo A Liu <shuo.a.liu@intel.com>
wenlingz pushed a commit that referenced this issue Jun 19, 2019
Remove the use of assert() in passthrough driver.

Tracked-On: #3252
Signed-off-by: Binbin Wu <binbin.wu@intel.com>
Reviewed-by: Shuo A Liu <shuo.a.liu@intel.com>
wenlingz pushed a commit that referenced this issue Jun 19, 2019
This patch is to clean up assert from virtio-net.
Tracked-On: #3252

Signed-off-by: Jie Deng <jie.deng@intel.com>
Reviewed-by: Shuo A Liu <shuo.a.liu@intel.com>
yonghuah added a commit to yonghuah/acrn-hypervisor that referenced this issue Jun 19, 2019
  cleanup 'assert' to avoid possible vulnerabilities.

Tracked-On: projectacrn#3252
Signed-off-by: Yonghua Huang <yonghua.huang@intel.com>
Reviewed-by: Shuo A Liu <shuo.a.liu@intel.com>
yonghuah added a commit to yonghuah/acrn-hypervisor that referenced this issue Jun 19, 2019
 - 'assert' cleanup
 - fix memory leakage in vrtc_init()

Tracked-On: projectacrn#3252
Signed-off-by: Yonghua Huang <yonghua.huang@intel.com>
Reviewed-by: Shuo A Liu <shuo.a.liu@intel.com>
yonghuah added a commit to yonghuah/acrn-hypervisor that referenced this issue Jun 19, 2019
 - 'assert' cleanup to avoid possible software vulnerabilities.

Tracked-On: projectacrn#3252
Signed-off-by: Yonghua Huang <yonghua.huang@intel.com>
Reviewed-by: Shuo A Liu <shuo.a.liu@intel.com>
yonghuah added a commit to yonghuah/acrn-hypervisor that referenced this issue Jun 19, 2019
 cleanup 'assert' to avoid possible software vulnerabilities

Tracked-On: projectacrn#3252
Signed-off-by: Yonghua Huang <yonghua.huang@intel.com>
Reviewed-by: Shuo A Liu <shuo.a.liu@intel.com>
yonghuah added a commit to yonghuah/acrn-hypervisor that referenced this issue Jun 19, 2019
  cleanup 'assert' usage to avoid possible software vulnerabilities.

Tracked-On: projectacrn#3252
Signed-off-by: Yonghua Huang <yonghua.huang@intel.com>
Reviewed-by: Shuo A Liu <shuo.a.liu@intel.com>
yonghuah added a commit to yonghuah/acrn-hypervisor that referenced this issue Jun 19, 2019
 'assert' usage cleanup to avoid possible software vulnerabilities

Tracked-On: projectacrn#3252
Signed-off-by: Yonghua Huang <yonghua.huang@intel.com>
Reviewed-by: Shuo A Liu <shuo.a.liu@intel.com>
yonghuah added a commit to yonghuah/acrn-hypervisor that referenced this issue Jun 19, 2019
  cleanup 'assert' usage to avoid possible software vulnerabilities

Tracked-On: projectacrn#3252
Signed-off-by: Yonghua Huang <yonghua.huang@intel.com>
Reviewed-by: Shuo A Liu <shuo.a.liu@intel.com>
conghuic23 added a commit to conghuic23/acrn-hypervisor that referenced this issue Jun 19, 2019
This patch is to clean up assert for block interface.
'magic' is removed from block structure, as the user should make sure
the block device is created and not closed when access to it.

Tracked-On: projectacrn#3252
Signed-off-by: Conghui Chen <conghui.chen@intel.com>
Reviewed-by: Shuo A Liu <shuo.a.liu@intel.com>
conghuic23 added a commit to conghuic23/acrn-hypervisor that referenced this issue Jun 19, 2019
This patch is to clean up assert from achi.

Tracked-On: projectacrn#3252
Signed-off-by: Conghui Chen <conghui.chen@intel.com>
Reviewed-by: Shuo A Liu <shuo.a.liu@intel.com>
conghuic23 added a commit to conghuic23/acrn-hypervisor that referenced this issue Jun 19, 2019
This patch is to clean up assert from virtio-block

Tracked-On: projectacrn#3252
Signed-off-by: Conghui Chen <conghui.chen@intel.com>
Reviewed-by: Shuo A Liu <shuo.a.liu@intel.com>
conghuic23 added a commit to conghuic23/acrn-hypervisor that referenced this issue Jun 19, 2019
This patch is to clean up assert for block interface.
'magic' is removed from block structure, as the user should make sure
the block device is created and not closed when access to it.

Tracked-On: projectacrn#3252
Signed-off-by: Conghui Chen <conghui.chen@intel.com>
Reviewed-by: Shuo A Liu <shuo.a.liu@intel.com>
conghuic23 added a commit to conghuic23/acrn-hypervisor that referenced this issue Jun 19, 2019
This patch is to clean up assert from achi.

Tracked-On: projectacrn#3252
Signed-off-by: Conghui Chen <conghui.chen@intel.com>
Reviewed-by: Shuo A Liu <shuo.a.liu@intel.com>
conghuic23 added a commit to conghuic23/acrn-hypervisor that referenced this issue Jun 19, 2019
This patch is to clean up assert from virtio-block

Tracked-On: projectacrn#3252
Signed-off-by: Conghui Chen <conghui.chen@intel.com>
Reviewed-by: Shuo A Liu <shuo.a.liu@intel.com>
conghuic23 added a commit to conghuic23/acrn-hypervisor that referenced this issue Jun 19, 2019
This patch is to clean up assert from virtio-block

Tracked-On: projectacrn#3252
Signed-off-by: Conghui Chen <conghui.chen@intel.com>
Reviewed-by: Shuo A Liu <shuo.a.liu@intel.com>
shuox pushed a commit to shuox/acrn-hypervisor that referenced this issue Jun 19, 2019
Tracked-On: projectacrn#3252
Signed-off-by: Shuo A Liu <shuo.a.liu@intel.com>
shuox pushed a commit to shuox/acrn-hypervisor that referenced this issue Jun 19, 2019
Tracked-On: projectacrn#3252
Signed-off-by: Shuo A Liu <shuo.a.liu@intel.com>
shuox pushed a commit to shuox/acrn-hypervisor that referenced this issue Jun 19, 2019
Tracked-On: projectacrn#3252
Signed-off-by: Shuo A Liu <shuo.a.liu@intel.com>
wenlingz pushed a commit that referenced this issue Jun 20, 2019
Tracked-On: #3252
Signed-off-by: Shuo A Liu <shuo.a.liu@intel.com>
Reviewed-by: Yonghua Huang <yonghua.huang@intel.com>
wenlingz pushed a commit that referenced this issue Jun 20, 2019
Tracked-On: #3252
Signed-off-by: Shuo A Liu <shuo.a.liu@intel.com>
Reviewed-by: Yonghua Huang <yonghua.huang@intel.com>
wenlingz pushed a commit that referenced this issue Jun 20, 2019
Tracked-On: #3252
Signed-off-by: Shuo A Liu <shuo.a.liu@intel.com>
Reviewed-by: Yonghua Huang <yonghua.huang@intel.com>
dongyaozu pushed a commit that referenced this issue Jun 20, 2019
This patch is to clean up assert from ioc

Tracked-On: #3252
Signed-off-by: Yuan Liu <yuan1.liu@intel.com>
Reviewed-by: Shuo A Liu <shuo.a.liu@intel.com>
dongyaozu pushed a commit that referenced this issue Jun 20, 2019
This patch is to clean up assert from virtio-gpio

Tracked-On: #3252
Signed-off-by: Yuan Liu <yuan1.liu@intel.com>
Reviewed-by: Shuo A Liu <shuo.a.liu@intel.com>
chejianj added a commit to chejianj/acrn-hypervisor that referenced this issue Jun 24, 2019
Remove unnecessary assert and add error handling when required.

Tracked-On: projectacrn#3252
Signed-off-by: Jian Jun Chen <jian.jun.chen@intel.com>
Reviewed-by: Shuo A Liu <shuo.a.liu@intel.com>
acrnsi pushed a commit that referenced this issue Jun 24, 2019
Remove unnecessary assert and add error handling when required.

Tracked-On: #3252
Signed-off-by: Jian Jun Chen <jian.jun.chen@intel.com>
Reviewed-by: Shuo A Liu <shuo.a.liu@intel.com>
yingbinx added a commit to yingbinx/acrn-hypervisor that referenced this issue Jun 24, 2019
clean up assert from virtio rpmb module.

Tracked-On: projectacrn#3252
Signed-off-by: dengwei <wei.a.deng@intel.com>
Signed-off-by: yingbinx <yingbinx.zeng@intel.com>
Acked-by: Zhu Bing <bing.zhu@intel.com>
acrnsi pushed a commit that referenced this issue Jun 24, 2019
clean up assert from virtio rpmb module.

Tracked-On: #3252
Signed-off-by: dengwei <wei.a.deng@intel.com>
Signed-off-by: yingbinx <yingbinx.zeng@intel.com>
Acked-by: Zhu Bing <bing.zhu@intel.com>
xiaoguangwu added a commit to xiaoguangwu/acrn-hypervisor that referenced this issue Jun 26, 2019
Remove assert in USB mediator code.

Tracked-On: projectacrn#3252
Signed-off-by: Xiaoguang Wu <xiaoguang.wu@intel.com>
xiaoguangwu added a commit to xiaoguangwu/acrn-hypervisor that referenced this issue Jun 26, 2019
Remove assert in USB mediator code.

Tracked-On: projectacrn#3252
Signed-off-by: Xiaoguang Wu <xiaoguang.wu@intel.com>
Reviewed-by: Shuo A Liu <shuo.a.liu@intel.com>
dongyaozu pushed a commit that referenced this issue Jun 26, 2019
Remove assert in USB mediator code.

Tracked-On: #3252
Signed-off-by: Xiaoguang Wu <xiaoguang.wu@intel.com>
Reviewed-by: Shuo A Liu <shuo.a.liu@intel.com>
peterfang added a commit to peterfang/acrn-hypervisor that referenced this issue Jul 3, 2019
Remove the use of assert() in vPIT.

Tracked-On: projectacrn#3252
Signed-off-by: Peter Fang <peter.fang@intel.com>
Reviewed-by: <yonghua.huang@intel.com>
Acked-by: Yin, Fengwei <fengwei.yin@intel.com>
peterfang added a commit to peterfang/acrn-hypervisor that referenced this issue Jul 3, 2019
Remove the use of assert() in vHPET.

Tracked-On: projectacrn#3252
Signed-off-by: Peter Fang <peter.fang@intel.com>
Reviewed-by: <yonghua.huang@intel.com>
Acked-by: Yin, Fengwei <fengwei.yin@intel.com>
peterfang added a commit to peterfang/acrn-hypervisor that referenced this issue Jul 3, 2019
errx() does not require an additional exit().

Tracked-On: projectacrn#3252
Signed-off-by: Peter Fang <peter.fang@intel.com>
Reviewed-by: <yonghua.huang@intel.com>
Acked-by: Yin, Fengwei <fengwei.yin@intel.com>
wenlingz pushed a commit that referenced this issue Jul 3, 2019
Remove the use of assert() in vPIT.

Tracked-On: #3252
Signed-off-by: Peter Fang <peter.fang@intel.com>
Reviewed-by: <yonghua.huang@intel.com>
Acked-by: Yin, Fengwei <fengwei.yin@intel.com>
wenlingz pushed a commit that referenced this issue Jul 3, 2019
Remove the use of assert() in vHPET.

Tracked-On: #3252
Signed-off-by: Peter Fang <peter.fang@intel.com>
Reviewed-by: <yonghua.huang@intel.com>
Acked-by: Yin, Fengwei <fengwei.yin@intel.com>
wenlingz pushed a commit that referenced this issue Jul 3, 2019
errx() does not require an additional exit().

Tracked-On: #3252
Signed-off-by: Peter Fang <peter.fang@intel.com>
Reviewed-by: <yonghua.huang@intel.com>
Acked-by: Yin, Fengwei <fengwei.yin@intel.com>
yonghuah added a commit to yonghuah/acrn-hypervisor that referenced this issue Jul 4, 2019
 - check input by condition check, instead of assert.
 - remove redundant header file including for some files.

Tracked-On: projectacrn#3252
Signed-off-by: Yonghua Huang <yonghua.huang@intel.com>
Reviewed-by: Shuo Liu <shuo.a.liu@intel.com>
gaojunhao0504 added a commit to gaojunhao0504/acrn-hypervisor that referenced this issue Jul 4, 2019
clean up assert in virtio_rnd.c

Tracked-On: projectacrn#3252
Signed-off-by: Gao Junhao <junhao.gao@intel.com>
Reviewed-by: Yonghua Huang <yonghua.huang@intel.com>
acrnsi pushed a commit that referenced this issue Jul 5, 2019
 - check input by condition check, instead of assert.
 - remove redundant header file including for some files.

Tracked-On: #3252
Signed-off-by: Yonghua Huang <yonghua.huang@intel.com>
Reviewed-by: Shuo Liu <shuo.a.liu@intel.com>
acrnsi pushed a commit that referenced this issue Jul 5, 2019
clean up assert in virtio_rnd.c

Tracked-On: #3252
Signed-off-by: Gao Junhao <junhao.gao@intel.com>
Reviewed-by: Yonghua Huang <yonghua.huang@intel.com>
@Mingyuan18
Copy link
Author

The patch was merged and no regression in daily test.
ACRN Tag: acrn-2019w29.1-140000p
CL: 30340

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: P2-High type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants