Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System is lagging when execute "fdisk -l" to query disk information with multiple USB devices after launch or reboot UOS #3401

Closed
Mingyuan18 opened this issue Jul 12, 2019 · 2 comments
Closed

System is lagging when execute "fdisk -l" to query disk information with multiple USB devices after launch or reboot UOS #3401

Mingyuan18 opened this issue Jul 12, 2019 · 2 comments
Assignees
@xiaoguangwu
Labels
priority: P3-Medium type: bug Something isn't working
Projects
Roadmap

Comments

@Mingyuan18
Copy link

Mingyuan18 commented Jul 12, 2019 •
edited by lirui34

Environment:
HW/Board：VBS KBL NUC
NUC Type: BLKNUC7 i5DNH1E
Image info:
IOC/SBL version: NUC don't have IOC.
SOS version: 30000
SOS kernel version: Linux 1024017924sos-dom0 4.19.40-quilt-2e5dc0ac-00009-g407db14980fb #1 SMP PREEMPT Thu Jun 20 02:34:19 UTC 2019 x86_64 GNU/Linux
ACRN version: daily tag:acrn-2019w23.4-140000p
UOS Type: VBS LaaG
UOS version: 30000
UOS kernel version: Linux clr-8c05224c49ab41e0b11b00d789f05d1f 4.19.40-quilt-2e5dc0ac-00009-g407db14980fb #1 SMP PREEMPT Thu Jun 20 02:35:59 UTC 2019 x86_64 GNU/Linux
steps:
1:insert USB Hub in standard A port, and insert several USB flash sticks(contain USB2.0,USB3.0,USB GPS) in this Hub to cover all Hub ports
2:boot uos by sharing the one-tiered USB Hub in cmd line
-s n,xhci,1-1:1-2:1-3:1-4:2-1:2-2:2-3:2-4
3: can recognize all USB flash disks, and can mount/read/write all USB flash sticks in uos.
root@clr-8c05224c49ab41e0b11b00d789f05d1f ~ # fdisk -l |grep dev
Disk /dev/ram0: 16 MiB, 16777216 bytes, 32768 sectors
Disk /dev/ram1: 16 MiB, 16777216 bytes, 32768 sectors
Disk /dev/ram2: 16 MiB, 16777216 bytes, 32768 sectors
Disk /dev/ram3: 16 MiB, 16777216 bytes, 32768 sectors
Disk /dev/ram4: 16 MiB, 16777216 bytes, 32768 sectors
Disk /dev/ram5: 16 MiB, 16777216 bytes, 32768 sectors
Disk /dev/ram6: 16 MiB, 16777216 bytes, 32768 sectors
Disk /dev/ram7: 16 MiB, 16777216 bytes, 32768 sectors
Disk /dev/ram8: 16 MiB, 16777216 bytes, 32768 sectors
Disk /dev/ram9: 16 MiB, 16777216 bytes, 32768 sectors
Disk /dev/ram10: 16 MiB, 16777216 bytes, 32768 sectors
Disk /dev/ram11: 16 MiB, 16777216 bytes, 32768 sectors
Disk /dev/ram12: 16 MiB, 16777216 bytes, 32768 sectors
Disk /dev/ram13: 16 MiB, 16777216 bytes, 32768 sectors
Disk /dev/ram14: 16 MiB, 16777216 bytes, 32768 sectors
Disk /dev/ram15: 16 MiB, 16777216 bytes, 32768 sectors
Disk /dev/vda: 8.6 GiB, 9169755648 bytes, 17909679 sectors
/dev/vda1 2048 1046527 1044480 510M EFI System
/dev/vda2 1046528 1114111 67584 33M Linux swap
/dev/vda3 1114112 17891327 16777216 8G Linux root (x86-64)
Disk /dev/sdb: 59.2 GiB, 63518539776 bytes, 124059648 sectors
[ 932.116894] usb 1-1: reset high-speed USB device number 2 using xhci_hcd
Expected result:
Step 3, can use "fdisk -l" to very smooth to query disk information.
Actual result:
Step 3, when use "fdisk -l" to query disk information，the system is lagging
Reproduce rate: 100%
Debugging info:
please see the attachment.
@Mingyuan18
Copy link
Author

[External_System_ID] ACRN-4248

@Mingyuan18 Mingyuan18 added priority: P3-Medium type: bug Something isn't working labels Jul 12, 2019
xiaoguangwu added a commit to xiaoguangwu/acrn-hypervisor that referenced this issue Jul 12, 2019
@xiaoguangwu
DM USB: xHCI: change log for convenience of debugging
1a50583 
Not change code logic, just modify some logging code.

Tracked-On: projectacrn#3401
Signed-off-by: Xiaoguang Wu <xiaoguang.wu@intel.com>
Acked-by: Yu Wang <yu1.wang@intel.com>
xiaoguangwu added a commit to xiaoguangwu/acrn-hypervisor that referenced this issue Jul 12, 2019
@xiaoguangwu
DM USB: xHCI: refine the logic of Stop Endpoint cmd
e3de99a 
When the Stop Endpoint command is trapped, should not clear all
the data structure. Instead, only reset the ring buffer.

The reason is the xHCI may continue queue TRB without doing whole
initializing process again.

Tracked-On: projectacrn#3401
Signed-off-by: Xiaoguang Wu <xiaoguang.wu@intel.com>
Acked-by: Yu Wang <yu1.wang@intel.com>
xiaoguangwu added a commit to xiaoguangwu/acrn-hypervisor that referenced this issue Jul 12, 2019
@xiaoguangwu
DM USB: xHCI: add the resume state for PLS bits
b558a12 
Add resume state for the Port Link Status (PLS) bits.

Tracked-On: projectacrn#3401
Signed-off-by: Xiaoguang Wu <xiaoguang.wu@intel.com>
Acked-by: Yu Wang <yu1.wang@intel.com>
xiaoguangwu added a commit to xiaoguangwu/acrn-hypervisor that referenced this issue Jul 12, 2019
@xiaoguangwu
DM USB: xHCI: fix corner case of short packet logic
b9f7c27 
The old logic identify the short packet complete status (CS) by
comparing the transfered bytes (TB) and the expected transfered
bytes (ETB), it is right only when no error happend. If error
appears, the TB may be less than the ETB, but DM should report
error CS instead of short packet CS.

Tracked-On: projectacrn#3401
Signed-off-by: Xiaoguang Wu <xiaoguang.wu@intel.com>
Acked-by: Yu Wang <yu1.wang@intel.com>
@xiaoguangwu xiaoguangwu mentioned this issue Jul 12, 2019
Merged
wenlingz pushed a commit that referenced this issue Jul 12, 2019
@xiaoguangwu @wenlingz
DM USB: xHCI: change log for convenience of debugging
5686898 
Not change code logic, just modify some logging code.

Tracked-On: #3401
Signed-off-by: Xiaoguang Wu <xiaoguang.wu@intel.com>
Acked-by: Yu Wang <yu1.wang@intel.com>
wenlingz pushed a commit that referenced this issue Jul 12, 2019
@xiaoguangwu @wenlingz
DM USB: xHCI: refine the logic of Stop Endpoint cmd
c3d4cc3 
When the Stop Endpoint command is trapped, should not clear all
the data structure. Instead, only reset the ring buffer.

The reason is the xHCI may continue queue TRB without doing whole
initializing process again.

Tracked-On: #3401
Signed-off-by: Xiaoguang Wu <xiaoguang.wu@intel.com>
Acked-by: Yu Wang <yu1.wang@intel.com>
wenlingz pushed a commit that referenced this issue Jul 12, 2019
@xiaoguangwu @wenlingz
DM USB: xHCI: add the resume state for PLS bits
32d186b 
Add resume state for the Port Link Status (PLS) bits.

Tracked-On: #3401
Signed-off-by: Xiaoguang Wu <xiaoguang.wu@intel.com>
Acked-by: Yu Wang <yu1.wang@intel.com>
wenlingz pushed a commit that referenced this issue Jul 12, 2019
@xiaoguangwu @wenlingz
DM USB: xHCI: fix corner case of short packet logic
7a3ea2a 
The old logic identify the short packet complete status (CS) by
comparing the transfered bytes (TB) and the expected transfered
bytes (ETB), it is right only when no error happend. If error
appears, the TB may be less than the ETB, but DM should report
error CS instead of short packet CS.

Tracked-On: #3401
Signed-off-by: Xiaoguang Wu <xiaoguang.wu@intel.com>
Acked-by: Yu Wang <yu1.wang@intel.com>
@Mingyuan18
Copy link
Author

Verify this issue in below build, the result is pass:
ACRN TAG: daily tag:acrn-2019w28.5-140000p
CL: 30340

@wenlingz wenlingz added this to v1.2 in Roadmap Aug 13, 2019
@lirui34 lirui34 changed the title When launch or reboot UOS execute "fdisk -l" to query disk information with multiple USB devices,It will be caton phenomenon System is lagging when execute "fdisk -l" to query disk information with multiple USB devices after launch or reboot UOS Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xiaoguangwu xiaoguangwu

Labels
priority: P3-Medium type: bug Something isn't working
Projects
Roadmap
  
v1.2
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xiaoguangwu @Mingyuan18