New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dm: virtio: check for paddr_guest2host return value #5453
Conversation
|
No new violations to the coding guideline detected. |
|
OK to verify |
|
No new violations to the coding guideline detected. |
|
@tomasbw |
|
@tomasbw SW_LOAD: entry[0]: addr 0x0000000000000000, size 0x00000000000a0000, type 0x1 |
|
@tomasbw please check your patch: virtio_vq_init: vq enable failed |
paddr_guest2host can return NULL, but code paths in virtio are not checking the return value. _vq_record() initializes iov_base pointer using paddr_guest2host() but there is nothing in the flow that checks for NULL. Chane _vq_record to return -1 in case the address translation has failed. Tracked-On: projectacrn#5452 Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> Acked-by: Wang, Yu1 <yu1.wang@intel.com>
5ae9ffe
to
ae0ab82
Compare
|
the issue was fixed, missing return before the error label. |
|
No new violations to the coding guideline detected. |
paddr_guest2host can return NULL, but code paths in virtio
are not checking the return value.
_vq_record() initializes iov_base pointer using paddr_guest2host()
but there is nothing in the flow that checks for NULL.
Chane _vq_record to return -1 in case the address translation
has failed.
Tracked-On: #5452
Signed-off-by: Tomas Winkler tomas.winkler@intel.com
Acked-by: Wang, Yu1 yu1.wang@intel.com