This repository has been archived by the owner on Oct 10, 2020. It is now read-only.
Atomic/scan.py: Add rootfs to self.mount_paths BZ:1461788 #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a rootfs is scanned, it needs its dir added to self.mount_paths so that it can be unmounted properly. Failure to do so was resulting in a read-only filesystem error during scan clean ups because atomic deletes the temporary directory with shutil.rmtree.
|
LGTM |
|
☀️ Test successful - status-redhatci |
dharmit
added a commit
to dharmit/container-pipeline-service
that referenced
this pull request
Jul 20, 2017
This hot-fix is based on projectatomic/atomic#1037 and needs to be removed after atomic package in CentOS gets updated.
dharmit
added a commit
to dharmit/container-pipeline-service
that referenced
this pull request
Jul 20, 2017
This hot-fix is based on projectatomic/atomic#1037 and needs to be removed after atomic package in CentOS gets updated.
dharmit
added a commit
to dharmit/cccp-provisions
that referenced
this pull request
Oct 15, 2017
This hot-fix is based on projectatomic/atomic#1037 and needs to be removed after atomic package in CentOS gets updated.
navidshaikh
added a commit
to navidshaikh/container-pipeline-service
that referenced
this pull request
Mar 2, 2018
Needed hotfixes earlier when patches to atomic did not land in current release. Removed patches for: - projectatomic/atomic#804 - projectatomic/atomic@a261270 - projectatomic/atomic#1037
navidshaikh
added a commit
to navidshaikh/container-pipeline-service
that referenced
this pull request
Mar 2, 2018
Needed hotfixes earlier when patches to atomic did not land in current release. Removed patches for: - projectatomic/atomic#804 - projectatomic/atomic@a261270 - projectatomic/atomic#1037 Its fixed now, references: - projectatomic/atomic#804 (comment) - https://github.com/projectatomic/atomic/blob/master/Atomic/scan.py#L488 - https://github.com/projectatomic/atomic/blob/master/Atomic/scan.py#L157
navidshaikh
added a commit
to navidshaikh/container-pipeline-service
that referenced
this pull request
Mar 2, 2018
Needed hotfixes earlier when patches to atomic did not land in current release. Removed patches for: - projectatomic/atomic#804 - projectatomic/atomic@a261270 - projectatomic/atomic#1037 Its fixed now, references: - projectatomic/atomic#804 (comment) - https://github.com/projectatomic/atomic/blob/master/Atomic/scan.py#L488 - https://github.com/projectatomic/atomic/blob/master/Atomic/scan.py#L157
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a rootfs is scanned, it needs its dir added to self.mount_paths
so that it can be unmounted properly. Failure to do so was resulting
in a read-only filesystem error during scan clean ups because atomic
deletes the temporary directory with shutil.rmtree.
Related Bugzillas
Pull Request Checklist:
If your Pull request contains new features or functions, tests are required. If the PR is a bug fix and no tests exist, please consider adding some to prevent regressions.