Run args should include /bin/sh #877

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@rhatdan
Member
rhatdan commented Feb 7, 2017

No description provided.

@rhatdan rhatdan Run args should include /bin/sh
5d1f610
@rhatdan
Member
rhatdan commented Feb 7, 2017

@baude I think this fixes the issue.

atomic run fedora

Is supposed to work.

@jlebon
Member
jlebon commented Feb 7, 2017

Is that what we want though? Shouldn't we just let docker pick up the default CMD?

@rhatdan
Member
rhatdan commented Feb 7, 2017

This change is wrong, problem is deeper in the code.

@rhatdan rhatdan closed this Feb 7, 2017
@rhatdan
Member
rhatdan commented Feb 7, 2017

jlebon, there is no default command, but maybe you are right. Perhaps we should look for command or entrypoint inside of the image and then fall over to /bin/sh

@rhatdan
Member
rhatdan commented Feb 7, 2017

@jlebon ^^ @baude ^^

Bottom line is we need to get back to what we had before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment