Default to 'yes' for lvcreate prompts #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently lvcreate detects xfs signature at the beginning of the volume and asks for a confirmation to zero it (the default behavior). Because there is no stdin attached - confirmation is not given and lvcreate just creates the volume without zeroing its beginning. This in turn leads to an error with mkfs. Adding -y to lvcreate forces a yes answer to zeriong confirmation prompt and makes sure that volume beginning will be properly cleared.
|
This pull requests presumably is an alternative fix for the same issue as #62. |
|
LGTM. |
shishir-a412ed
approved these changes
Dec 20, 2018
|
Yay! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
lvcreatedetectsxfssignature at the beginning of the volume and asks for a confirmation to zero it (the default behavior).Because there is no
stdinattached - confirmation is not given andlvcreatejust creates the volume without zeroing its beginning.This in turn leads to an error with
mkfs.Adding
-ytolvcreateforces a yes answer to zeriong confirmation prompt and makes sure that volume beginning will be properly cleared.