Fix docker cp error per BZ1723491 #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
|
LGTM |
This was referenced Jun 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: TomSweeneyRedHat tsweeney@redhat.com
- What I did
In the containerArchivePath, change the call at line 155
from
filepath.Base(absPath)which if our target was/areturnedonly 'a', to
filepath.Dir(absPath)which instead returns '/'. Thename of the file is added during the copy operation.
Many thanks to @nalind for the investigative lead.
Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=1723491
- How I did it
vi is my friend.
- How to verify it
Did a number 'docker cp' commands to verify happiness.
- Description for the changelog
Fixes docker cp failure
- A picture of a cute animal (not mandatory but encouraged)