Skip to content
This repository has been archived by the owner on Jan 19, 2018. It is now read-only.

Use list of apps instead of magic key naming #35

Closed
aweiteka opened this issue May 4, 2015 · 2 comments · Fixed by #42
Closed

Use list of apps instead of magic key naming #35

aweiteka opened this issue May 4, 2015 · 2 comments · Fixed by #42

Comments

@aweiteka
Copy link
Contributor

aweiteka commented May 4, 2015

Looking at a Kubernetes API issue they point out the potential for confusion when using arbitrary names for keys. Consider A vs B:

A, current spec:

graph:
  mariadb-app:
    params:
      ...
    artifacts:
      ...

B, proposed

graph:
  - name: mariadb-app
    params:
      ...
    artifacts:
      ...

I think B is clearer that we're not doing something magic with the keys; They're just arbitrary names. Note we would have to bump the spec version with this change.

@aweiteka aweiteka changed the title Use list of apps instead of magic keys Use list of apps instead of magic key naming May 4, 2015
@vpavlin
Copy link
Contributor

vpavlin commented May 4, 2015

I guess this would be also case for params. Not sure if anything else carries same semantics, but I'd say components and params are the only ones we designed this way

@aweiteka
Copy link
Contributor Author

aweiteka commented May 7, 2015

As a user I was a bit confused about which key to use for params, so I agree. So if we have the same treatment for params...

graph:
  - name: mariadb-app
    params:
      - name: password
        description: db passphrase
      - name: image
        description: db image
        default: vpavlin/mariadb
    artifacts:
    ...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants