Allow a user to disable oci-register-machine #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oci-register-machine can be considered an information leak for certain container workloads. It allows information about the container to be viewed by non privileged users. Some adinistrators may want to disable containers reporting this information to systemd-machinectl. We want this package installed by default, and removing this package is not an option on atomic host. This patch adds a /etc/oci-register-machine.conf which contains a json data to disable the tool.
|
The goal of this is to fix https://bugzilla.redhat.com/show_bug.cgi?id=1366402 |
|
LGTM
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oci-register-machine can be considered an information leak for
certain container workloads. It allows information about the container
to be viewed by non privileged users. Some adinistrators may want to disable
containers reporting this information to systemd-machinectl. We want this
package installed by default, and removing this package is not an option
on atomic host.
This patch adds a /etc/oci-register-machine.conf which contains a json
data to disable the tool.