Only report an error on Terminate machine, if machine exists. #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are failing oci-register-machine Terminate if the container PID 1 does not exist. We should let the caller handle this, since the act of calling us was to kill this process.
|
This should fix https://bugzilla.redhat.com/show_bug.cgi?id=1380685 |
|
I'll test this out and report back |
|
👍 |
|
I hate doing the string contains, but I don't believe there is a way to get ENOEXIST or something from the dbus call. |
|
@lsm5 we need a new version of oci-register-machine. For F25, Rawhide, F24, RHEL7.3.1 |
|
works like a charm though 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are failing oci-register-machine Terminate if the container PID 1
does not exist. We should let the caller handle this, since the act
of calling us was to kill this process.