Support "bundle" in addition to "bundlePath" #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we change this, will it break on Docker which uses older versions of runc? |
|
Without this PR I'm getting error: With the PR, |
giuseppe
force-pushed
the
rename-bundlePath-to-bundle
branch
from
9b865c9
to
10a2d87
Compare
giuseppe
changed the title
|
@rhatdan yes, true. I've pushed a new version that supports both variants. |
giuseppe
force-pushed
the
rename-bundlePath-to-bundle
branch
from
10a2d87
to
cf51e26
Compare
It was changed in the OCI runtime spec to 1.0.0.rc5, so support both versions. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
rename-bundlePath-to-bundle
branch
from
cf51e26
to
8431edd
Compare
|
I can confirm that updated PR still works for me. |
pschiffe
pushed a commit
to pschiffe/gce-system-container
that referenced
this pull request
Sep 13, 2017
until projectatomic/oci-register-machine#33 is resolved
|
LGTM |
|
I have pushed updated versions of oci-register-machine into fedora updates testing. Please test and give good karma. |
|
Awesome thanks. We also need updated rpm in RHEL Atomic Host - I've created bz here: https://bugzilla.redhat.com/show_bug.cgi?id=1491461 |
|
Yup, I asked @lsm5 to make this available in 7.4.2 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was changed in the OCI runtime spec to 1.0.0.rc5
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com