[4.8] cgroupv1 freezer: thaw to increase freeze chances #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
huh, we have gh actions now, and they're also failing :) |
Ah, this is because of rc1 which got removed. Fixed by #42 |
It appears that briefly thawing the cgroup while freezing greatly increases its chances to freeze successfully. The test case I used is doing runc exec in a look parallel with runc pause/resume in another loop, and the failure to freeze rate reduced from 40 to 0 per minute (tested inside a VM using a busybox container running sleep 1h, doing about 1500 pause/resumes and 650 execs per minute), with max retries being 150 (of 1000). This is still a game of chances, so failures are possible. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> (cherry picked from commit d1007b0) Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
force-pushed
the
4.8-freeze-race
branch
from
b74933e
to
ea14ea2
Compare
|
rebased on top of merged #42 to make ci green |
|
LGTM, I'll merge with green CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports opencontainers/runc#2791 to rhaos-4.8 branch (i.e. on top of runc 1.0.0-rc93). In case we won't be upgrading to rc94 (once out) in 4.8, this may be of use.
This should fix https://bugzilla.redhat.com/show_bug.cgi?id=1903228
Original description follows
It appears that briefly thawing the cgroup while freezing
greatly increases its chances to freeze successfully.
The test case I used is doing runc exec in a look parallel with runc
pause/resume in another loop, and the failure to freeze rate reduced
from 40 to 0 per minute (tested inside a VM using a busybox container
running sleep 1h, doing about 1500 pause/resumes and 650 execs per
minute), with max retries being 150 (of 1000).
This is still a game of chances, so failures are possible.
Signed-off-by: Kir Kolyshkin kolyshkin@gmail.com
(cherry picked from commit d1007b0)
Signed-off-by: Kir Kolyshkin kolyshkin@gmail.com