switch to vndr #284

Merged
merged 1 commit into from Jan 9, 2017

Projects

None yet

2 participants

@runcom
Member
runcom commented Jan 9, 2017 edited

vndr is almost exactly the same as our old good hack/vendor.sh. Except
it's cleaner and it allows to re-vendor just one dependency if needed
(which we do a lot for containers/image).

close #135

Signed-off-by: Antonio Murdaca runcom@redhat.com

@runcom
Member
runcom commented Jan 9, 2017 edited

@mtrmac PTAL - from now on, there would be no need to run hack/vendor.sh to vendor every dependency. Instead vndr github.com/containers/image should just vendor c/image instantly (since it's tiny).
Note that I've explicitly left hack/vendor.sh around if anyone is so used to that and want to re-vendor everything.

@mtrmac

LGTM apart from that one line.

Also, this supersedes #135, doesn’t it?

-clone git github.com/urfave/cli v1.17.0
-clone git github.com/containers/image master
-clone git github.com/opencontainers/go-digest master
@mtrmac
mtrmac Jan 9, 2017 Collaborator

This is the only item which has not been replicated in the new vendor.conf, and it does seem necessary:

rm -rf /vendor/*/; vndr does not recreate vendor/github.com/opencontainers/go-digest.

@runcom
runcom Jan 9, 2017 Member

great catch 👍

@runcom
Member
runcom commented Jan 9, 2017

Also, this supersedes #135, doesn’t it?

it does, yes

@runcom runcom switch to vndr
vndr is almost exactly the same as our old good hack/vendor.sh. Except
it's cleaner and it allows to re-vendor just one dependency if needed
(which we do a lot for containers/image).

Signed-off-by: Antonio Murdaca <runcom@redhat.com>
fefeeb4
@mtrmac
Collaborator
mtrmac commented Jan 9, 2017

👍

@mtrmac
mtrmac approved these changes Jan 9, 2017 View changes
@runcom runcom merged commit 9b6b57d into projectatomic:master Jan 9, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@runcom runcom deleted the runcom:switch-to-vndr branch Jan 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment