From 1fa5d03cc0d383f310c2636f8745ff70d89a55a8 Mon Sep 17 00:00:00 2001
From: Chris Beer <chris@cbeer.info>
Date: Sat, 21 Jan 2017 17:18:13 -0800
Subject: [PATCH] Update .rubocop_todo.yml

---
 .rubocop_todo.yml | 56 +++++++++++++++++++++++++++++------------------
 1 file changed, 35 insertions(+), 21 deletions(-)

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index d1c11904a3..d61d410e34 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2016-10-31 11:13:16 -0700 using RuboCop version 0.45.0.
+# on 2017-01-21 17:17:40 -0800 using RuboCop version 0.47.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -17,18 +17,24 @@ Lint/UselessAssignment:
     - 'lib/blacklight/solr/response/spelling.rb'
     - 'lib/railties/blacklight.rake'
 
-# Offense count: 60
+# Offense count: 61
 Metrics/AbcSize:
   Max: 53
 
+# Offense count: 4
+# Configuration parameters: CountComments, ExcludedMethods.
+Metrics/BlockLength:
+  Max: 94
+
 # Offense count: 1
+# Configuration parameters: CountBlocks.
 Metrics/BlockNesting:
   Max: 4
 
 # Offense count: 2
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
-  Max: 200
+  Max: 181
 
 # Offense count: 20
 Metrics/CyclomaticComplexity:
@@ -53,6 +59,18 @@ Metrics/ParameterLists:
 Metrics/PerceivedComplexity:
   Max: 14
 
+# Offense count: 1
+# Configuration parameters: Blacklist.
+# Blacklist: decrement!, decrement_counter, increment!, increment_counter, toggle!, touch, update_all, update_attribute, update_column, update_columns, update_counters
+Rails/SkipsModelValidations:
+  Exclude:
+    - 'app/controllers/concerns/blacklight/saved_searches.rb'
+
+# Offense count: 1
+Security/MarshalLoad:
+  Exclude:
+    - 'lib/blacklight/configuration.rb'
+
 # Offense count: 2
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
@@ -87,7 +105,7 @@ Style/BracesAroundHashParameters:
 
 # Offense count: 8
 # Cop supports --auto-correct.
-# Configuration parameters: IndentWhenRelativeTo, SupportedStyles, IndentOneStep, IndentationWidth.
+# Configuration parameters: EnforcedStyle, SupportedStyles, IndentOneStep, IndentationWidth.
 # SupportedStyles: case, end
 Style/CaseIndentation:
   Exclude:
@@ -95,7 +113,7 @@ Style/CaseIndentation:
     - 'app/presenters/blacklight/index_presenter.rb'
     - 'lib/blacklight/configuration/fields.rb'
 
-# Offense count: 50
+# Offense count: 51
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 # SupportedStyles: nested, compact
 Style/ClassAndModuleChildren:
@@ -103,13 +121,13 @@ Style/ClassAndModuleChildren:
 
 # Offense count: 2
 # Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, SingleLineConditionsOnly.
+# Configuration parameters: EnforcedStyle, SupportedStyles, SingleLineConditionsOnly, IncludeTernaryExpressions.
 # SupportedStyles: assign_to_condition, assign_inside_condition
 Style/ConditionalAssignment:
   Exclude:
     - 'lib/blacklight/solr/response/spelling.rb'
 
-# Offense count: 91
+# Offense count: 92
 Style/Documentation:
   Enabled: false
 
@@ -127,6 +145,7 @@ Style/DoubleNegation:
   Exclude:
     - 'lib/blacklight/search_builder.rb'
 
+# Offense count: 13
 # Cop supports --auto-correct.
 # Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
 Style/ExtraSpacing:
@@ -135,13 +154,14 @@ Style/ExtraSpacing:
     - 'app/models/concerns/blacklight/document/dublin_core.rb'
     - 'app/models/record_mailer.rb'
     - 'config/routes.rb'
-    - 'lib/blacklight/configuration.rb'
-    - 'lib/generators/blacklight/controller_generator.rb'
-    - 'lib/generators/blacklight/document_generator.rb'
-    - 'lib/generators/blacklight/install_generator.rb'
-    - 'lib/generators/blacklight/search_builder_generator.rb'
     - 'lib/railties/blacklight.rake'
-    - 'tasks/blacklight.rake'
+
+# Offense count: 2
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: format, sprintf, percent
+Style/FormatString:
+  Exclude:
+    - 'app/helpers/blacklight/render_partials_helper_behavior.rb'
 
 # Offense count: 9
 # Configuration parameters: MinBodyLength.
@@ -153,7 +173,7 @@ Style/GuardClause:
     - 'app/helpers/blacklight/catalog_helper_behavior.rb'
     - 'lib/blacklight/solr/search_builder_behavior.rb'
 
-# Offense count: 103
+# Offense count: 99
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
 # SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys
@@ -184,22 +204,16 @@ Style/IndentHash:
   Exclude:
     - 'lib/blacklight/configuration.rb'
 
-# Offense count: 20
+# Offense count: 6
 # Cop supports --auto-correct.
 # Configuration parameters: Width.
 Style/IndentationWidth:
   Exclude:
     - 'app/controllers/concerns/blacklight/bookmarks.rb'
     - 'app/controllers/concerns/blacklight/token_based_user.rb'
-    - 'app/helpers/blacklight/catalog_helper_behavior.rb'
-    - 'app/helpers/blacklight/facets_helper_behavior.rb'
     - 'app/helpers/blacklight/render_constraints_helper_behavior.rb'
-    - 'app/helpers/blacklight/render_partials_helper_behavior.rb'
-    - 'app/helpers/blacklight/url_helper_behavior.rb'
     - 'app/models/concerns/blacklight/configurable.rb'
-    - 'lib/blacklight/search_builder.rb'
     - 'lib/blacklight/solr/response/facets.rb'
-    - 'lib/blacklight/solr/search_builder_behavior.rb'
     - 'lib/generators/blacklight/assets_generator.rb'
 
 # Offense count: 5