From 2c5fe3abd114ffe880d1dac47a536df862bf125b Mon Sep 17 00:00:00 2001 From: Jack Reed Date: Thu, 25 Jan 2018 18:12:18 -0700 Subject: [PATCH] failing test for #label_for_search_field where no search fields are configured --- spec/helpers/configuration_helper_spec.rb | 23 +++++++++++++++-------- 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/spec/helpers/configuration_helper_spec.rb b/spec/helpers/configuration_helper_spec.rb index 75bd680ad1..7d396aca3f 100644 --- a/spec/helpers/configuration_helper_spec.rb +++ b/spec/helpers/configuration_helper_spec.rb @@ -272,16 +272,23 @@ end describe "#label_for_search_field" do - before do - blacklight_config.add_search_field 'title', :qt => 'title_search' - end + context 'with search fields' do + before do + blacklight_config.add_search_field 'title', :qt => 'title_search' + end - it "finds label by key" do - expect(helper.label_for_search_field("title")).to eq "Title" - end + it "finds label by key" do + expect(helper.label_for_search_field("title")).to eq "Title" + end - it "supplies default label for key not found" do - expect(helper.label_for_search_field("non_existent_key")).to eq "Non existent key" + it "supplies default label for key not found" do + expect(helper.label_for_search_field("non_existent_key")).to eq "Non existent key" + end + end + context 'without search fields' do + it "finds label by key" do + expect(helper.label_for_search_field(nil)).to eq "Keyword" + end end end end