From 9adcac1ce147f9b7b8e68a09750c087370e31af5 Mon Sep 17 00:00:00 2001 From: Jack Reed Date: Fri, 27 Feb 2015 07:17:49 -0800 Subject: [PATCH] add in more link purpose for screen readers --- app/views/catalog/_facet_limit.html.erb | 6 ++++-- config/locales/blacklight.de.yml | 2 ++ config/locales/blacklight.en.yml | 2 ++ config/locales/blacklight.es.yml | 2 ++ config/locales/blacklight.fr.yml | 2 ++ config/locales/blacklight.pt-BR.yml | 2 ++ spec/features/facets_spec.rb | 8 ++++++++ 7 files changed, 22 insertions(+), 2 deletions(-) diff --git a/app/views/catalog/_facet_limit.html.erb b/app/views/catalog/_facet_limit.html.erb index 1d9430d6a2..c623107c61 100644 --- a/app/views/catalog/_facet_limit.html.erb +++ b/app/views/catalog/_facet_limit.html.erb @@ -3,7 +3,9 @@ <%= render_facet_limit_list paginator, field_name %> <% unless paginator.last_page? || params[:action] == "facet" %> - + <% end %> diff --git a/config/locales/blacklight.de.yml b/config/locales/blacklight.de.yml index 0650ce116d..87406e7e52 100644 --- a/config/locales/blacklight.de.yml +++ b/config/locales/blacklight.de.yml @@ -183,7 +183,9 @@ de: count: 'Numerisch ordnen' index: 'A-Z Ordnen' count: '%{number}' + # i18n key 'more' is deprecated and will be removed in Blacklight 6.0 more: 'mehr »' + more_html: 'mehr %{field_name} »' selected: remove: '[entfernen]' group: diff --git a/config/locales/blacklight.en.yml b/config/locales/blacklight.en.yml index 94e6261e97..deece2f7e7 100644 --- a/config/locales/blacklight.en.yml +++ b/config/locales/blacklight.en.yml @@ -183,7 +183,9 @@ en: count: 'Numerical Sort' index: 'A-Z Sort' count: '%{number}' + # i18n key 'more' is deprecated and will be removed in Blacklight 6.0 more: 'more »' + more_html: 'more %{field_name} »' selected: remove: '[remove]' group: diff --git a/config/locales/blacklight.es.yml b/config/locales/blacklight.es.yml index fdcd11d2b9..6404702c55 100644 --- a/config/locales/blacklight.es.yml +++ b/config/locales/blacklight.es.yml @@ -183,7 +183,9 @@ es: count: 'Ordenación numérica' index: 'Ordenación A-Z' count: '%{number}' + # i18n key 'more' is deprecated and will be removed in Blacklight 6.0 more: 'más »' + more_html: 'más %{field_name} »' selected: remove: '[borrar]' group: diff --git a/config/locales/blacklight.fr.yml b/config/locales/blacklight.fr.yml index c52fd312bf..8b88ff2a1b 100755 --- a/config/locales/blacklight.fr.yml +++ b/config/locales/blacklight.fr.yml @@ -199,7 +199,9 @@ fr: count: 'Du + au - fréquent' index: 'Tri de A à Z' count: '%{number}' + # i18n key 'more' is deprecated and will be removed in Blacklight 6.0 more: 'plus »' + more_html: 'plus %{field_name} »' selected: remove: '[ X ]' group: diff --git a/config/locales/blacklight.pt-BR.yml b/config/locales/blacklight.pt-BR.yml index e2d633aa4a..a0df19ecda 100644 --- a/config/locales/blacklight.pt-BR.yml +++ b/config/locales/blacklight.pt-BR.yml @@ -203,7 +203,9 @@ pt-BR: count: 'Ordenar por Número' index: 'Ordem Alfabética A-Z' count: '%{number}' + # i18n key 'more' is deprecated and will be removed in Blacklight 6.0 more: 'mais »' + more_html: 'mais %{field_name} »' selected: remove: '[remover]' filters: diff --git a/spec/features/facets_spec.rb b/spec/features/facets_spec.rb index ac1fe9c065..4a031eae11 100644 --- a/spec/features/facets_spec.rb +++ b/spec/features/facets_spec.rb @@ -32,4 +32,12 @@ end + describe '"More" links' do + it 'has default more link with sr-only text' do + visit root_path + within '#facet-language_facet' do + expect(page).to have_css 'li.more_facets_link', text: 'more' + end + end + end end