New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse RBAC into calico.yaml #2234

Merged
merged 2 commits into from Oct 17, 2018

Conversation

Projects
None yet
3 participants
@caseydavenport
Copy link
Member

caseydavenport commented Oct 16, 2018

Description

Build on top of this PR: #2233

Todos

  • Tests
  • Documentation
  • Release note

Release Note

For ease of deployment the RBAC manifest has been removed. It is now combined with the main Calico manifest.  Any install scripts that rely on installing the RBAC manifest will need to be updated.

@caseydavenport caseydavenport requested a review from emanic Oct 16, 2018

@caseydavenport caseydavenport requested a review from projectcalico/core-maintainers as a code owner Oct 16, 2018

@caseydavenport

This comment has been minimized.

Copy link
Member

caseydavenport commented Oct 16, 2018

CC @2ffs2nns I think once this goes in, our Jenkins jobs might stop working since they'll expect an rbac file that no longer exists.

@caseydavenport caseydavenport referenced this pull request Oct 16, 2018

Closed

Folds RBAC into main manifests #2233

0 of 2 tasks complete

@caseydavenport caseydavenport added this to the Calico v3.4.0 milestone Oct 16, 2018

---
layout: null
---
{% include {{page.version}}/manifests/rbac-etcd-calico.yaml %}

This comment has been minimized.

@fasaxc

fasaxc Oct 16, 2018

Member

What's with these new RBAC files (I must be missing something!)?

This comment has been minimized.

@emanic

emanic Oct 16, 2018

Member

These are there primarily to handle the integration use case. I think it is just a matter of adding the flags, as per @caseydavenport 's new changes. I can take a stab at it.

- kind: ServiceAccount
name: canal
namespace: kube-system
{%- endif %}

This comment has been minimized.

@emanic

emanic Oct 16, 2018

Member

Wow, looks so much better @caseydavenport 💯


[Click here to view the above yaml directly.](rbac.yaml)
```
kubectl apply -f {{site.url}}/{{page.version}}/manifests/rbac-etcd-flannel.yaml

This comment has been minimized.

@emanic

emanic Oct 16, 2018

Member

Maybe the above bullets need adjustment now though @caseydavenport

This comment has been minimized.

@caseydavenport

caseydavenport Oct 17, 2018

Member

Which ones?

@emanic

emanic approved these changes Oct 17, 2018

Copy link
Member

emanic left a comment

Looks good!

@emanic

This comment has been minimized.

Copy link
Member

emanic commented Oct 17, 2018

🎉

@caseydavenport caseydavenport force-pushed the caseydavenport:emanic-collapse-rbac branch from cb52e0c to a2b94a3 Oct 17, 2018

@caseydavenport caseydavenport merged commit 3092d19 into projectcalico:master Oct 17, 2018

2 checks passed

license/cla Contributor License Agreement is signed.
Details
semaphoreci The build passed on Semaphore.
Details

@caseydavenport caseydavenport deleted the caseydavenport:emanic-collapse-rbac branch Oct 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment