Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates the top level navbar and reorganizes existing content to fit #2372

Merged
merged 1 commit into from Jan 31, 2019

Conversation

Projects
None yet
2 participants
@emanic
Copy link
Member

emanic commented Jan 16, 2019

Description

  • Updates the topic titles in the top-level navbar
  • Reorganizes the existing content to fit under these new headings/categories
  • Adds attributions

Todos

  • Tests
  • Documentation
  • Release note

Release Note

None required

@emanic emanic added the hold-merge label Jan 16, 2019

@emanic emanic requested a review from projectcalico/core-maintainers as a code owner Jan 16, 2019

@caseydavenport

This comment has been minimized.

Copy link
Member

caseydavenport commented Jan 16, 2019

Deploy preview for calico ready!

Built with commit 6895bd4

https://deploy-preview-2372--calico.netlify.com

@caseydavenport

This comment has been minimized.

Copy link
Member

caseydavenport commented Jan 16, 2019

Deploy preview for calico ready!

Built with commit d599031

https://deploy-preview-2372--calico.netlify.com

@emanic emanic force-pushed the emanic:top-nav-reorg branch from d94bd7a to c67890b Jan 24, 2019

@emanic emanic changed the title [WIP] Updates the top level navbar and reorganizes existing content to fit Updates the top level navbar and reorganizes existing content to fit Jan 24, 2019

@emanic emanic removed the hold-merge label Jan 24, 2019

@emanic emanic force-pushed the emanic:top-nav-reorg branch from c67890b to 912ddb6 Jan 24, 2019

@@ -1,5 +1,5 @@
---
title: Using etcd RBAC to segment Kubernetes and Calico
title: Segmenting etcd on Kubernetes (basic)

This comment has been minimized.

@caseydavenport

caseydavenport Jan 25, 2019

Member

Should all the "Configuring etcd RBAC" content go under "Security" rather than "Reference"? WDYT?

This comment has been minimized.

@emanic

emanic Jan 25, 2019

Author Member

I personally agree with you one hundred percent, if you wanted to take this up with AP perhaps we could do that.

@emanic emanic force-pushed the emanic:top-nav-reorg branch 2 times, most recently from 86d60be to 79b79ea Jan 25, 2019

@emanic emanic changed the title Updates the top level navbar and reorganizes existing content to fit [WIP] Updates the top level navbar and reorganizes existing content to fit Jan 28, 2019

@emanic emanic changed the title [WIP] Updates the top level navbar and reorganizes existing content to fit Updates the top level navbar and reorganizes existing content to fit Jan 28, 2019

@emanic emanic force-pushed the emanic:top-nav-reorg branch 6 times, most recently from 09a43aa to cfad9dc Jan 28, 2019

@emanic emanic force-pushed the emanic:top-nav-reorg branch 2 times, most recently from eff7a6f to d599031 Jan 29, 2019

@@ -99,15 +99,38 @@
</div>
<div id="tigera-navbar" class="navbar-collapse collapse">
<ul class="nav navbar-nav navbar-right">

This comment has been minimized.

@caseydavenport

caseydavenport Jan 30, 2019

Member

nit: I think there's a corresponding line in RELEASING.md that needs to be updated for this change

Add TWO new

  • entries to the in _layouts/docwithnav.html file.

  • TWO probably goes to ONE now?

    @caseydavenport
    Copy link
    Member

    caseydavenport left a comment

    @emanic there's one more comment to address re: RELEASING.md, but then this LGTM.

    @caseydavenport caseydavenport merged commit 6f60040 into projectcalico:master Jan 31, 2019

    2 checks passed

    license/cla Contributor License Agreement is signed.
    Details
    semaphoreci The build passed on Semaphore.
    Details
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    You can’t perform that action at this time.