Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manifests to version root for simpler URLs #2437

Merged

Conversation

Projects
None yet
3 participants
@caseydavenport
Copy link
Member

commented Feb 22, 2019

This shortens and standardizes the URLs for manifests for each release. I've just copied over the yamls into a new location, leaving the old URLs intact for now. This will give us a grace period before we remove the old ones.

They are both generated from the same templates so any changes will show up in both places.

For example, these URLs in the current docs:

would become these URLs after this PR:

Simplify Kubernetes manifest URL locations. Existing URLs have been left intact, but will be removed in a future release. Please update any tooling to use the new manifest URLs.

@caseydavenport caseydavenport added this to the Calico v3.6.0 milestone Feb 22, 2019

@caseydavenport caseydavenport requested a review from projectcalico/core-maintainers Feb 22, 2019

@caseydavenport

This comment has been minimized.

Copy link
Member Author

commented Feb 22, 2019

Deploy preview for calico ready!

Built with commit 7381f75

https://deploy-preview-2437--calico.netlify.com

@caseydavenport caseydavenport changed the title Add manifests to verion root for simpler URLs Add manifests to version root for simpler URLs Feb 23, 2019

@caseydavenport

This comment has been minimized.

Copy link
Member Author

commented Feb 25, 2019

Still need to do ALP manifests.

Might want to keep some sort of simple hierarchy given the number of manifests.

e.g.:

@caseydavenport caseydavenport force-pushed the caseydavenport:better-manifest-urls branch from 66e300c to a0f4906 Feb 25, 2019

@fasaxc

This comment has been minimized.

Copy link
Member

commented Feb 26, 2019

Some of the manifests seem bigger than I was expecting (i.e. a full inline yaml rather than an include). If we're going to have these in two places can you make them includes of a shared file instead?

@caseydavenport caseydavenport force-pushed the caseydavenport:better-manifest-urls branch 6 times, most recently from aa8896c to 40c140c Apr 17, 2019

@caseydavenport caseydavenport requested a review from fasaxc Apr 17, 2019

@caseydavenport caseydavenport force-pushed the caseydavenport:better-manifest-urls branch from 40c140c to d44756f Apr 19, 2019

@@ -4,5 +4,4 @@ layout: null
{% helm %}

This comment has been minimized.

Copy link
@caseydavenport

caseydavenport Apr 19, 2019

Author Member

This diff is confusing - I didn't move these, I just deleted the unused ALP manifests.

@caseydavenport caseydavenport force-pushed the caseydavenport:better-manifest-urls branch from d44756f to cf8f3ae Apr 19, 2019

@ozdanborne
Copy link
Member

left a comment

Overall, the design implied by these changes LGTM. This diff is a bit too dense for me to find any typos though. Guess we'll rely on the tests for that

@caseydavenport caseydavenport force-pushed the caseydavenport:better-manifest-urls branch from 849835d to 7381f75 Apr 19, 2019

@caseydavenport caseydavenport merged commit ff5aee5 into projectcalico:master Apr 19, 2019

1 of 2 checks passed

semaphoreci The build is pending on Semaphore.
Details
license/cla Contributor License Agreement is signed.
Details

@caseydavenport caseydavenport deleted the caseydavenport:better-manifest-urls branch Apr 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.