Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the manifest to call http URL instead of typha health check command #2482

Merged
merged 3 commits into from Mar 11, 2019

Conversation

Projects
None yet
3 participants
@roshanirathi
Copy link
Contributor

commented Mar 11, 2019

Description

Todos

  • Tests
  • Documentation
  • Release note

Release Note

Update Typha's Kubernetes readiness check to call Typha directly

@roshanirathi roshanirathi requested a review from projectcalico/core-maintainers as a code owner Mar 11, 2019

@caseydavenport

This comment has been minimized.

Copy link
Member

commented Mar 11, 2019

Deploy preview for calico ready!

Built with commit 0a0dfc6

https://deploy-preview-2482--calico.netlify.com

- calico-typha
- check
- liveness
- curl https://127.0.0.1:5473/liveness

This comment has been minimized.

Copy link
@fasaxc

fasaxc Mar 11, 2019

Member

This shouldn't use curl here, it should use k8s' native HTTP readiness probe.

See the example here: https://github.com/projectcalico/calico/blob/master/_includes/master/manifests/calico-node.yaml#L307

- liveness
httpGet:
path: /liveness
port: 5473

This comment has been minimized.

Copy link
@fasaxc

fasaxc Mar 11, 2019

Member

5473 is Typha's main port but the healthcheck is on port 9098

This comment has been minimized.

Copy link
@roshanirathi

roshanirathi Mar 11, 2019

Author Contributor

Ack

@fasaxc

fasaxc approved these changes Mar 11, 2019

@fasaxc fasaxc merged commit 8d40a25 into projectcalico:master Mar 11, 2019

2 checks passed

license/cla Contributor License Agreement is signed.
Details
semaphoreci The build passed on Semaphore.
Details

@caseydavenport caseydavenport added this to the Calico v3.7.0 milestone Mar 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.