Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign calico components critical priority #2564

Merged
merged 1 commit into from Apr 24, 2019

Conversation

Projects
None yet
3 participants
@tomastigera
Copy link
Contributor

commented Apr 22, 2019

Any other components besides node, controllers and typha? Etcd seems to be excluded since 3.6

Description

As of k8s 1.14 the critical annotation is deprecated by setting
priorities. k8s define system-node/cluster-critical priorities in the
reserved range to be assigned to critical components.

Critical annotations remain set for compatibility with previous k8s
versions.

fixes OS-3511

Tests

Not sure how to test this beyond verifying that the priorities are set

Namespace:          kube-system
Priority:           2000001000
PriorityClassName:  system-node-critical
Node:               minikube/10.0.2.15
Start Time:         Thu, 18 Apr 2019 17:05:44 -0700
Labels:             controller-revision-hash=6bfbcd8744
                    k8s-app=calico-node
                    pod-template-generation=1
Annotations:        scheduler.alpha.kubernetes.io/critical-pod: 
Status:             Running
IP:                 10.0.2.15
Controlled By:      DaemonSet/calico-node
...

Release Note

Assign priority classes to Calico components
Assign calico components critical priority
As of k8s 1.14 the critical annotation is deprecated by setting
priorities. k8s define system-node/cluster-critical priorities in the
reserved range to be assigned to critical components.

Critical annotations remain set for compatibility with previous k8s
versions.

fixes OS-3511

@tomastigera tomastigera requested a review from projectcalico/core-maintainers as a code owner Apr 22, 2019

@caseydavenport

This comment has been minimized.

Copy link
Member

commented Apr 22, 2019

Deploy preview for calico ready!

Built with commit 54e8ec3

https://deploy-preview-2564--calico.netlify.com

@caseydavenport caseydavenport added this to the Calico v3.8.0 milestone Apr 24, 2019

@caseydavenport caseydavenport merged commit 6914a6a into projectcalico:master Apr 24, 2019

2 checks passed

license/cla Contributor License Agreement is signed.
Details
semaphoreci The build passed on Semaphore.
Details

@tomastigera tomastigera deleted the tomastigera:tomas-OS-3511 branch Apr 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.