Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add read access to canal cluster role for namespaces #2566

Merged
merged 2 commits into from Apr 25, 2019

Conversation

Projects
None yet
4 participants
@asincu
Copy link
Contributor

commented Apr 23, 2019

Description

Add read access to canal cluster role to include namespaces to the manifest for canal with etcd datastore. This changes will be applied for versions after 3.6.

Todos

  • Tests
  • Documentation
  • Release note

Release Note

Enhance canal manifest with etcd datastore to include read access to namespaces for canal cluster role.

@asincu asincu requested a review from projectcalico/core-maintainers as a code owner Apr 23, 2019

@caseydavenport

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

Deploy preview for calico ready!

Built with commit 98bf036

https://deploy-preview-2566--calico.netlify.com

@caseydavenport

This comment has been minimized.

Copy link
Member

commented Apr 24, 2019

@asincu this LGTM - could you also make the change in the corresponding v3.7 manifest?

@caseydavenport caseydavenport added this to the Calico v3.7.0 milestone Apr 24, 2019

@asincu asincu force-pushed the asincu:canal branch from 70c408f to 98bf036 Apr 25, 2019

@lwr20

lwr20 approved these changes Apr 25, 2019

Copy link
Member

left a comment

LGTM

@caseydavenport caseydavenport merged commit d067787 into projectcalico:master Apr 25, 2019

2 checks passed

license/cla Contributor License Agreement is signed.
Details
semaphoreci The build passed on Semaphore.
Details

@asincu asincu deleted the asincu:canal branch Apr 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.