Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Istio 1.1 configmaps #2619

Merged
merged 5 commits into from May 23, 2019

Conversation

Projects
None yet
4 participants
@spikecurtis
Copy link
Member

commented May 21, 2019

Description

Adds Istio sidecar injector ConfigMaps for multiple Istio versions, including up to 1.1.7.

However, as we haven't decided whether to officially support Istio 1.1 in the next Calico release, we keep the install instructions pointed at Istio 1.0.7. A follow up PR will update these instructions to point to the latest Istio if we decide to ship it in the next release.

Note that this will break our E2Es without a corresponding PR that updates the URL to download the ConfigMap. Spike will coordinate merging such a PR on the same day as this so overnight E2E impact will be mitigated.

This PR also adds explicit text around updating Calico when ALP is enabled.

Todos

  • Tests
  • Documentation
  • Release note

Release Note

Sidecar injector ConfigMaps for multiple Istio versions, URL changed

spikecurtis added some commits May 20, 2019

Istio 1.1.x ConfigMaps & updated instructions
Signed-off-by: Spike Curtis <spike@tigera.io>
Also include Istio 1.0.7 and 1.0.6 configmaps
Signed-off-by: Spike Curtis <spike@tigera.io>
Add upgrade instructions for ALP
Signed-off-by: Spike Curtis <spike@tigera.io>
Refactor ALP upgrade doc
Signed-off-by: Spike Curtis <spike@tigera.io>
Keep instructions on Istio 1.0.7
Signed-off-by: Spike Curtis <spike@tigera.io>

@spikecurtis spikecurtis requested a review from neiljerram May 21, 2019

@spikecurtis spikecurtis requested a review from projectcalico/core-maintainers as a code owner May 21, 2019

@caseydavenport

This comment has been minimized.

Copy link
Member

commented May 21, 2019

Deploy preview for calico ready!

Built with commit 9b757bc

https://deploy-preview-2619--calico.netlify.com

@spikecurtis

This comment has been minimized.

Copy link
Member Author

commented May 21, 2019

@neiljerram Your JIRA write up for this included the idea about perhaps attempting to modify the ConfigMap the user has installed in place. In the end, I decided not to go down that route, and instead just provide example config maps for a variety of Istio versions. These end up being easy to add when new versions of Istio ship.

A utility that automatically inserts our stuff into the ConfigMap would end up having to be very sophisticated, or else it would be very fragile to updates from the Istio team. To do it robustly it would have to understand not only the podspec YAML, but also the templating language that Istio are using, which is probably intractable in the general case.

@neiljerram
Copy link
Member

left a comment

Looks very clean. My only query is about the removal of the calico-node.yaml files. Was that because they're now identical to YAML outside the 'app-layer-policy' tree, and so don't need duplicating?

@spikecurtis

This comment has been minimized.

Copy link
Member Author

commented May 22, 2019

Yeah, it looks like at some point we decided to have all manifests live in /<version>/manifests/... rather than /<version>/getting-started/kubernetes/hosted/... but didn't clean up the old manifests. I'm guessing this was because we didn't want to break wavetank URLs. Since I'm breaking URLs anyway with this change, I decided to do the cleanup.

@spikecurtis spikecurtis merged commit b2e1f6d into projectcalico:master May 23, 2019

2 checks passed

license/cla Contributor License Agreement is signed.
Details
semaphoreci The build passed on Semaphore.
Details

@spikecurtis spikecurtis deleted the spikecurtis:istio-1.1-configmap branch May 23, 2019

@caseydavenport caseydavenport added this to the Calico v3.8.0 milestone Jun 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.