Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Istio 1.1 configmaps #2619
Adds Istio sidecar injector ConfigMaps for multiple Istio versions, including up to 1.1.7.
However, as we haven't decided whether to officially support Istio 1.1 in the next Calico release, we keep the install instructions pointed at Istio 1.0.7. A follow up PR will update these instructions to point to the latest Istio if we decide to ship it in the next release.
Note that this will break our E2Es without a corresponding PR that updates the URL to download the ConfigMap. Spike will coordinate merging such a PR on the same day as this so overnight E2E impact will be mitigated.
This PR also adds explicit text around updating Calico when ALP is enabled.
@neiljerram Your JIRA write up for this included the idea about perhaps attempting to modify the ConfigMap the user has installed in place. In the end, I decided not to go down that route, and instead just provide example config maps for a variety of Istio versions. These end up being easy to add when new versions of Istio ship.
A utility that automatically inserts our stuff into the ConfigMap would end up having to be very sophisticated, or else it would be very fragile to updates from the Istio team. To do it robustly it would have to understand not only the podspec YAML, but also the templating language that Istio are using, which is probably intractable in the general case.
Yeah, it looks like at some point we decided to have all manifests live in