Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALP without daemonset redeploy #2633

Merged
merged 1 commit into from May 29, 2019

Conversation

Projects
None yet
3 participants
@spikecurtis
Copy link
Member

commented May 28, 2019

Signed-off-by: Spike Curtis spike@tigera.io

Description

Reconfigures the way we install & enable ALP.

  • Merge the default and ALP variants of calico-node so that we always install the FlexVolume driver and volumes
  • Remove the Policy Sync API path from environment variable on calico-node. Instead, instruct operators to set it using FelixConfiguration.

Todos

  • Tests
  • Documentation
  • Release note

Release Note

Includes App Layer Policy drivers & volumes in `calico-node` but leaves disabled by default.
ALP without daemonset redeploy
Signed-off-by: Spike Curtis <spike@tigera.io>

@spikecurtis spikecurtis requested a review from caseydavenport May 28, 2019

@spikecurtis spikecurtis requested a review from projectcalico/core-maintainers as a code owner May 28, 2019

@caseydavenport

This comment has been minimized.

Copy link
Member

commented May 28, 2019

Deploy preview for calico ready!

Built with commit d52266a

https://deploy-preview-2633--calico.netlify.com

@spikecurtis

This comment has been minimized.

Copy link
Member Author

commented May 28, 2019

Once this is merged we will have to merge tigera/wavetank-jobs#582 to fix E2Es that depended on the old install method.

@spikecurtis spikecurtis merged commit 24adc46 into projectcalico:master May 29, 2019

2 checks passed

license/cla Contributor License Agreement is signed.
Details
semaphoreci The build passed on Semaphore.
Details

@spikecurtis spikecurtis deleted the spikecurtis:alp-no-daemonset branch May 29, 2019

@caseydavenport caseydavenport added this to the Calico v3.8.0 milestone Jun 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.