Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement calicoctl patch #2054

Merged
merged 23 commits into from Sep 18, 2019

Conversation

@syscll
Copy link
Contributor

syscll commented Aug 30, 2019

Description

This is a base implementation of a new calicoctl patch command as requested in #2047

The end goal is to best match the implementation of kubectl patch. However, to start, the functionality of this PR will be limited to JSON data only and will perform a strategic merge patch as described here.

Todos

  • Tests
  • Documentation
  • Release note

Release Note

calicoctl now supports patching resources using `calicoctl patch`
syscll added 2 commits Aug 30, 2019
@caseydavenport caseydavenport added this to the Calico v3.10.0 milestone Sep 6, 2019
syscll added 3 commits Sep 9, 2019
@caseydavenport caseydavenport changed the title [WIP - DO NOT MERGE] Implement calicoctl patch Implement calicoctl patch Sep 12, 2019
@syscll

This comment has been minimized.

Copy link
Contributor Author

syscll commented Sep 13, 2019

Will add some unit and integration tests, as well as perform some manual testing.

syscll added 3 commits Sep 17, 2019
… into feature/calicoctl-patch
@syscll

This comment has been minimized.

Copy link
Contributor Author

syscll commented Sep 18, 2019

What's the procedure around release notes and docs? Do I just need to add a patch section to the calicoctl reference for v3.10?

@caseydavenport

This comment has been minimized.

Copy link
Member

caseydavenport commented Sep 18, 2019

@syscll yep - I've added a release note to the description which will get picked up during the next release.

We should add new documentation to the master/ directory of the Calico repo (since that will become v3.10). We'll definitely want the reference changes, we might also want to update some of our other docs which have users do a get->modify->update to just use patch instead, since it's way simpler.

@caseydavenport

This comment has been minimized.

Copy link
Member

caseydavenport commented Sep 18, 2019

Let's make sure to squash into one commit before merging.

@caseydavenport caseydavenport merged commit 70b0f4b into projectcalico:master Sep 18, 2019
2 checks passed
2 checks passed
license/cla Contributor License Agreement is signed.
Details
semaphoreci The build passed on Semaphore.
Details
@syscll syscll deleted the syscll:feature/calicoctl-patch branch Sep 18, 2019
@syscll syscll referenced this pull request Sep 18, 2019
0 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.