New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt CNI version to v0.7.1. #586

Merged
merged 1 commit into from Sep 5, 2018

Conversation

Projects
None yet
4 participants
@gyliu513
Contributor

gyliu513 commented Aug 31, 2018

Due to the hostPort does not work because of issue
containernetworking/plugins#81 , it is
better to upgrade CNI to 0.7.1 to fix this, this can also improve
the portmap performance.

Fixed #585

/cc @caseydavenport

Description

Todos

  • Tests
  • Documentation
  • Release note

Release Note

Prompt CNI version to v0.7.1.
@CLAassistant

This comment has been minimized.

CLAassistant commented Aug 31, 2018

CLA assistant check
All committers have signed the CLA.

@caseydavenport

This comment has been minimized.

Member

caseydavenport commented Sep 4, 2018

@gyliu513 thanks! I'd very much like to merge this.

However, it looks like the build is failing at the moment.

curl -sSf -L --retry 5 https://github.com/containernetworking/plugins/releases/download/v0.7.3/cni-plugins-amd64-v0.7.3.tgz | tar -xz -C bin/amd64 ./flannel ./loopback ./host-local ./portmap ./tuning
curl: (22) The requested URL returned error: 404 Not Found

gzip: stdin: unexpected end of file
tar: Child returned status 1
@gyliu513

This comment has been minimized.

Contributor

gyliu513 commented Sep 5, 2018

Thanks @caseydavenport , this seems to be an issue for containernetworking release, I opened an issue containernetworking/plugins#198 to trace it.

For now, I think we can upgrade to 0.7.1 release, as 0.7.1 also include the fix for #585

Prompt CNI version to v0.7.1.
Due to the hostPort does not work because of issue
containernetworking/plugins#81 , it is
better to upgrade CNI to 0.7.3 to fix this, this can also improve
the portmap performance.

@gyliu513 gyliu513 force-pushed the gyliu513:portmap branch from 05e9e2e to 23fb793 Sep 5, 2018

@gyliu513 gyliu513 changed the title from Prompt CNI version to v0.7.3. to Prompt CNI version to v0.7.1. Sep 5, 2018

@caseydavenport caseydavenport merged commit 9225cdb into projectcalico:master Sep 5, 2018

2 checks passed

license/cla Contributor License Agreement is signed.
Details
semaphoreci The build passed on Semaphore.
Details

@caseydavenport caseydavenport added this to the Calico v3.3.0 milestone Sep 5, 2018

@gyliu513 gyliu513 deleted the gyliu513:portmap branch Sep 6, 2018

@gyliu513

This comment has been minimized.

Contributor

gyliu513 commented Sep 6, 2018

@caseydavenport thanks, what is the release date of Calico v3.3.0?

@caseydavenport

This comment has been minimized.

Member

caseydavenport commented Sep 10, 2018

@gyliu513 we're still working on an exact date, but I'd expect sometime in the next month.

@cwedgwood

@caseydavenport the comment says "better to upgrade CNI to 0.7.3"

however the change is to 0.7.1

is that intentional?

@caseydavenport

This comment has been minimized.

Member

caseydavenport commented Oct 30, 2018

better to upgrade CNI to 0.7.1 to fix this,

v0.7.1 is the latest release that has binaries attached. v0.7.3 doesn't have any artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment