New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set interfaces.sandbox of CNI result empty #607

Merged
merged 1 commit into from Oct 2, 2018

Conversation

Projects
None yet
2 participants
@420691301
Contributor

420691301 commented Sep 30, 2018

Description

bug fix
According to cni 0.3.0 spec , interfaces.sandbox is required for container/hypervisor interfaces, empty/omitted for host interfaces.

If it's not empty, bandwidth cni will return error--"no host interface found."

Todos

  • Tests
  • Documentation
  • Release note

Release Note

Support CNI plugin chaining with the CNI bandwidth plugin

@caseydavenport caseydavenport merged commit 0c65443 into projectcalico:master Oct 2, 2018

2 checks passed

license/cla Contributor License Agreement is signed.
Details
semaphoreci The build passed on Semaphore.
Details

@caseydavenport caseydavenport added this to the Calico v3.3.0 milestone Oct 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment