Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed order of releasing IP and removing interface #746

Merged
merged 2 commits into from May 23, 2019

Conversation

Projects
None yet
5 participants
@jadech32
Copy link
Contributor

commented May 22, 2019

Description

Bug fix: Changed ordering of events so that IP is released after the interface is removed to prevent potential race condition / two interfaces sharing one IP

Todos

  • Tests
  • Documentation
  • Release note

Release Note

@CLAassistant

This comment has been minimized.

Copy link

commented May 22, 2019

CLA assistant check
All committers have signed the CLA.

@jpalardy
Copy link

left a comment

LGTM

Show resolved Hide resolved pkg/k8s/k8s.go Outdated
@caseydavenport
Copy link
Member

left a comment

@jadech32 just one comment, but otherwise looks good! Thanks!

@caseydavenport caseydavenport merged commit 900d217 into projectcalico:master May 23, 2019

2 checks passed

license/cla Contributor License Agreement is signed.
Details
semaphoreci The build passed on Semaphore.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.