Merge pull request #942 from neiljerram/fix-node-name-var #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert accidental change from KUBERNETES_NODE_NAME to NODENAME
nelljerram
added
docs-not-required
release-note-not-required
and removed
docs-pr-required
release-note-required
labels
3 tasks
|
Question, was this the reason why (on AWS, for example) if the $HOSTNAME would return "ip-x-y-z-w" but the node name was joined as "ip-x-y-z-w.ec2.internal", nodes would fail partway through joining? I had to work around this by forcing the short-name of AWS boxes to be the FQDN. Can I revert that if I update? |
|
Yes, that sounds like the issue I ran into: not on AWS but the symptoms are similar. You'll find that pods are created and scheduled on the node but can't actually start. This only affects Calico 3.16.0 though; 3.15 and lower were not affected, and fixed in 3.16.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert accidental change from KUBERNETES_NODE_NAME to NODENAME
Description
Todos
Release Note