Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added OnSync call if failed to create kubernetes api client for exte… #289

Merged

Conversation

@f41gh7
Copy link

f41gh7 commented Oct 25, 2019

additional call for onSync - if failed to created client

#288

Don't block if we fail to monitor services for advertisement
@CLAassistant

This comment has been minimized.

Copy link

CLAassistant commented Oct 25, 2019

CLA assistant check
All committers have signed the CLA.

…rnal ip advertisement.

 #288
@f41gh7 f41gh7 force-pushed the f41gh7:added-onsynccall-out-of-cluster branch from 236baf1 to 37d9c51 Oct 28, 2019
Copy link
Member

caseydavenport left a comment

This LGTM - but, I'm wondering if there's a scenario that's causing you to his this?

Ideally this branch never gets it, since I think it indicates a misconfiguration.

@caseydavenport

This comment has been minimized.

Copy link
Member

caseydavenport commented Oct 28, 2019

Ah, just saw the linked issue. WIll read through that.

@neiljerram

This comment has been minimized.

Copy link
Member

neiljerram commented Dec 5, 2019

@caseydavenport Just spotted this and wonder if it's correct for it still to be open?

@caseydavenport

This comment has been minimized.

Copy link
Member

caseydavenport commented Dec 6, 2019

@neiljerram yeah, this one slipped off my radar somehow.

I think we should merge this for v3.11. I think it's only an improvement on what happens today.

@caseydavenport caseydavenport added this to the Calico v3.11.0 milestone Dec 6, 2019
@caseydavenport caseydavenport merged commit 57e7673 into projectcalico:master Dec 6, 2019
2 checks passed
2 checks passed
license/cla Contributor License Agreement is signed.
Details
semaphoreci The build passed on Semaphore.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.