Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bird is adding a blackhole route to the service cluster CIDR that blo… #295

Merged
merged 5 commits into from Dec 5, 2019

Conversation

@rafaelvanoni
Copy link
Member

rafaelvanoni commented Nov 23, 2019

…cks access inside the cluster

See projectcalico/calico#2457

Fix Bird adding a blackhole route to the service cluster CIDR which blocks access inside the cluster
@neiljerram

This comment has been minimized.

Copy link
Member

neiljerram commented Nov 25, 2019

@rafaelvanoni Thanks. I'm just about to push a couple of tweaks to the templating, that should fix CI. Did you start looking at how to reproduce the problem scenario?

@rafaelvanoni

This comment has been minimized.

Copy link
Member Author

rafaelvanoni commented Nov 26, 2019

@rafaelvanoni Thanks. I'm just about to push a couple of tweaks to the templating, that should fix CI. Did you start looking at how to reproduce the problem scenario?

Thanks for those two fixes. I'm re-reviewing the comments on the issue and trying to figure out the data model changes per your comments on slack.

@neiljerram neiljerram force-pushed the rafaelvanoni:rafael-confd-3 branch from d92a76a to 65d6325 Dec 4, 2019
@neiljerram

This comment has been minimized.

Copy link
Member

neiljerram commented Dec 4, 2019

@rafaelvanoni Would you like to review the test that I've added for this? The key point is the static-routes-no-ipv4-address/input.yaml not configuring an IPv4 address for the node: 65d6325?file-filters%5B%5D=.yaml#diff-653ded2657f907212ee17ca239dc2978R11

Copy link
Member

neiljerram left a comment

LGTM

@neiljerram neiljerram merged commit 7d9ff97 into projectcalico:master Dec 5, 2019
2 checks passed
2 checks passed
license/cla Contributor License Agreement is signed.
Details
semaphoreci The build passed on Semaphore.
Details
@lmm lmm added this to the Calico v3.11.0 milestone Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.