Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add SNAT random-fully flag. #1901
Detect iptables version and pass feature flags around.
Use feature flag to control whether the --random-fully flag is included.
A few nits here; but also I'm tempted to think that having Features per-table is unnecessary, and that this change could be much smaller if it used a single global Features variable that is populated at start of day. (Then it doesn't need to be passed through everywhere.) WDYT? Am I missing an important benefit of the current arrangement?
I went that direction to make it easier to test in fully-deterministic way. A global variable doesn't fit well with ginkgo tests at all and once the table needs to be passed it, it needs to be passed down to the rules too (since the rules shouldn't be carrying around a feature flag pointer).