Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick iptables race fix for v3.8 #2102

Merged
merged 1 commit into from Aug 9, 2019

Conversation

@lmm
Copy link
Member

commented Aug 8, 2019

Fixes a race condition where a non-Calico iptables rule may be removed.

From #2088

Description

Todos

  • Unit tests (full coverage)
  • Integration tests (delete as appropriate) In plan/Not needed/Done
  • Documentation
  • Backport
  • Release note

Release Note

Fix race condition where a non-Calico rule may be deleted.
Merge pull request #2088 from lmm/lmm-full-rules
Delete rules using full line instead of line number for non-cali chains

(cherry picked from commit 1c3aa70)

@lmm lmm requested a review from projectcalico/core-maintainers as a code owner Aug 8, 2019

@marvin-tigera marvin-tigera modified the milestone: Calico v3.8.2 Aug 8, 2019

@fasaxc fasaxc self-assigned this Aug 9, 2019

@fasaxc
fasaxc approved these changes Aug 9, 2019

@lmm lmm merged commit 17cd9f5 into projectcalico:release-v3.8 Aug 9, 2019

2 checks passed

license/cla Contributor License Agreement is signed.
Details
semaphoreci The build passed on Semaphore.
Details

@lmm lmm deleted the lmm:v3.8-lmm-iptables-fix branch Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.