Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce severity of BPF log levels #2144

Merged
merged 1 commit into from Sep 10, 2019

Conversation

@tmjd
Copy link
Member

tmjd commented Sep 10, 2019

Description

Since we fallback to iptables if BPF is not able to be applied so reduce the log level when errors happen when applying.

Todos

Release Note

None required
@tmjd tmjd requested a review from projectcalico/core-maintainers as a code owner Sep 10, 2019
@@ -2155,8 +2155,8 @@ type xdpMemberCache struct {

func newXDPMemberCache(family bpf.IPFamily, bpfLib bpf.BPFDataplane) *xdpMemberCache {
return &xdpMemberCache{
family: family,
cache: make(map[string]map[bpf.CIDRMapKey]uint32),
family: family,

This comment has been minimized.

Copy link
@tmjd

tmjd Sep 10, 2019

Author Member

I don't know why my go fmt kept doing this.

This comment has been minimized.

Copy link
@caseydavenport

caseydavenport Sep 10, 2019

Member

Weird. What version of go do you have?

This comment has been minimized.

Copy link
@tmjd

tmjd Sep 10, 2019

Author Member

1.11.2, I should update.

Copy link
Member

caseydavenport left a comment

Barring the formatting change this LGTM.

We'll need to port to v3.9 as well.

@tmjd tmjd force-pushed the tmjd:lower-bpf-log-level branch from c1e40b1 to daf6bb1 Sep 10, 2019
@tmjd tmjd merged commit dbc6c9a into projectcalico:master Sep 10, 2019
2 checks passed
2 checks passed
license/cla Contributor License Agreement is signed.
Details
semaphoreci The build passed on Semaphore.
Details
@tmjd tmjd deleted the tmjd:lower-bpf-log-level branch Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.