Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Implementing backoff for XDP failures and eliminate panic behaviour for non-xdp non-responding kernels #2165
See projectcalico/calico#2904 for details on how I stumbled upon this. Also please not I'm new to project calico so feel free to scrutinize my logic if I'm missing something :)
The xdp_state.go function has some very important logic around reconcilation around BPF, and as I was looking at the code for the above issue, I found a that errors (1) were not explicitly returned, (2) not backedoff during retries . In looking at exactly what functionality might be failing under the hood i found that it was tricky to see exactly what was going on because (3) there was some coupling in the code that was using the
Thanks for the contribution, the fix looks good and the little refactoring too. Afraid I have to push back on the comment rewrites though; I don't think they are improvements as they stand.
The CI failed, you need to fix up