New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable node controller by default #220

Merged
merged 2 commits into from Sep 17, 2018

Conversation

Projects
None yet
4 participants
@nwt
Contributor

nwt commented Mar 1, 2018

Description

Documentation in projectcalico/calico states that all Kubernetes
controllers are enabled by default.

(Unless #180, which added the node controller, intentionally didn't enable it by default.)

Todos

Release Note

None required
Enable node controller by default
The documentation in projectcalico/calico states that all Kubernetes
controllers are enabled by default.
@caseydavenport

This comment has been minimized.

Member

caseydavenport commented Mar 1, 2018

I think it was intentional not to enable this by default, since it might have surprised users who simply upgraded from an earlier version. The intention was to make this explicitly "opt-in", so it's arguably a docs bug.

Thinking about it now, the controller will only have an impact when nodes are marked with the correct node references, so perhaps enabling by default isn't as bad as we thought. CC @ozdanborne.

@CLAassistant

This comment has been minimized.

CLAassistant commented Sep 14, 2018

CLA assistant check
All committers have signed the CLA.

@tomdee

This comment has been minimized.

Contributor

tomdee commented Sep 14, 2018

The Calico manifests turn it on so shouldn't be affected why this change in defaults.

@caseydavenport caseydavenport merged commit f32f6b9 into projectcalico:master Sep 17, 2018

2 checks passed

license/cla Contributor License Agreement is signed.
Details
semaphoreci The build passed on Semaphore.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment