Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller for cleaning up IPAM allocations #340

Merged
merged 4 commits into from Feb 21, 2019

Conversation

Projects
None yet
3 participants
@caseydavenport
Copy link
Member

caseydavenport commented Feb 11, 2019

Description

This controller cleans up IPAM allocations when pods / nodes are terminated in an "ungraceful" way.

It should handle a couple of cases:

  • Pods being deleted without a CNI "DEL" being executed.
  • Nodes being removed from the cluster when using KDD IPAM.

Requires this CNI PR: projectcalico/cni-plugin#680
Requires this Node PR: projectcalico/node#154

Todos

  • Tests
  • Documentation
  • Release note

Release Note

None required

@caseydavenport caseydavenport force-pushed the caseydavenport:casey-kdd-ipam branch 2 times, most recently from bf1e749 to 90a94e3 Feb 11, 2019

@briansan briansan referenced this pull request Feb 12, 2019

Merged

Store additional attributes with IP allocations #680

0 of 3 tasks complete

@caseydavenport caseydavenport force-pushed the caseydavenport:casey-kdd-ipam branch from cab0749 to 402e151 Feb 13, 2019

@@ -0,0 +1,144 @@
package node

This comment has been minimized.

@caseydavenport

caseydavenport Feb 13, 2019

Author Member

I just moved the existing logic into this file to keep the etcd and kdd logic separate.

@caseydavenport caseydavenport force-pushed the caseydavenport:casey-kdd-ipam branch 2 times, most recently from a12aec3 to 94d2672 Feb 13, 2019

@caseydavenport caseydavenport force-pushed the caseydavenport:casey-kdd-ipam branch from 94d2672 to 1214064 Feb 14, 2019

@caseydavenport caseydavenport force-pushed the caseydavenport:casey-kdd-ipam branch 3 times, most recently from 3c0669d to 6e36cd0 Feb 15, 2019

@caseydavenport caseydavenport requested a review from fasaxc Feb 20, 2019

@caseydavenport caseydavenport force-pushed the caseydavenport:casey-kdd-ipam branch 2 times, most recently from 245145c to 4c09f4f Feb 20, 2019

@caseydavenport caseydavenport force-pushed the caseydavenport:casey-kdd-ipam branch from 4c09f4f to fa8c30c Feb 20, 2019

@fasaxc
Copy link
Member

fasaxc left a comment

Looking good, just a few minor comments.

Show resolved Hide resolved pkg/controllers/node/kdd.go Outdated
Show resolved Hide resolved pkg/controllers/node/kdd.go Outdated
Show resolved Hide resolved pkg/controllers/node/etcd.go Outdated
Show resolved Hide resolved pkg/controllers/node/kdd.go Outdated
Show resolved Hide resolved tests/fv/kdd_node_ipam_test.go Outdated
Show resolved Hide resolved tests/fv/kdd_node_ipam_test.go

@caseydavenport caseydavenport force-pushed the caseydavenport:casey-kdd-ipam branch from c82d003 to 53be7f2 Feb 21, 2019

@caseydavenport caseydavenport merged commit 1cb6bba into projectcalico:master Feb 21, 2019

2 checks passed

license/cla Contributor License Agreement is signed.
Details
semaphoreci The build passed on Semaphore.
Details

@caseydavenport caseydavenport deleted the caseydavenport:casey-kdd-ipam branch Feb 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.