Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Support for Calico IPAM in KDD mode #1010
referenced this pull request
Feb 4, 2019
fasaxc left a comment
A few minor comments and one thought: should we try to hide the multi-stage deletion logic in the KDD layer rather than having to write code in the IPAM layer to do it? I.e. make it so that DeleteKVP does the CaS and then the delete with precondition.
I agree that hiding the logic within KDD implementation of DeleteKVP would be worth it. It would avoid having our etcd implementation go through these unnecessary checks since it is not vulnerable to this potential race. Seems like a pretty small change.. @caseydavenport WDYT
@fasaxc OK, I think it should all be addressed in the latest commit.
Note: I've bumped the "Burst" back up on the k8s client, since for some /32 blocksize allocations we require lots of datastore requests to find an unclaimed block, and to find an empty block. I've left the QPS at the default 5 though, as it seems to work fine.
I'd like to optimize that further later, but it needs more design and I'd rather not hold this PR up further on it.