Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed support for token environment variables support for KDD. #1023

Merged
merged 5 commits into from Feb 25, 2019

Conversation

Projects
None yet
3 participants
@tathagatachowdhury
Copy link
Contributor

tathagatachowdhury commented Feb 14, 2019

Description

Todos

  • Tests
  • Documentation
  • Release note

Release Note

Removed support for the K8S_API_TOKEN environment variable
K8sCertFile string `json:"k8sCertFile" envconfig:"K8S_CERT_FILE" default:""`
K8sCAFile string `json:"k8sCAFile" envconfig:"K8S_CA_FILE" default:""`
K8sAPIToken string `json:"k8sAPIToken" envconfig:"K8S_API_TOKEN" default:""`
K8sKeyFile string `json:"k8sKeyFile" default:""`

This comment has been minimized.

@fasaxc

fasaxc Feb 14, 2019

Member

I think you need to set ignored:"true", like you did for the new EtcdConfig fields

This comment has been minimized.

@tathagatachowdhury

tathagatachowdhury Feb 14, 2019

Author Contributor

Acknowledged and updated.

@fasaxc

This comment has been minimized.

Copy link
Member

fasaxc commented Feb 21, 2019

@caseydavenport was this what you had in mind? Just wanted to check you didn't mean to completely remove those config params.

@tathagatachowdhury tathagatachowdhury changed the title Removed the cert /token environment varibales support for KDD. Removed support for token environment variables support for KDD. Feb 25, 2019

@@ -121,7 +121,6 @@ kind: notCalicoApiConfig
"APIV1_K8S_CERT_FILE": "baz1",
"APIV1_K8S_KEY_FILE": "foo1",
"APIV1_K8S_CA_FILE": "foobar1",
"APIV1_K8S_API_TOKEN": "foobarbaz1",

This comment has been minimized.

@fasaxc

fasaxc Feb 25, 2019

Member

Suggest you leave the env var input in place (with comment // ignored for security reasons) but verify that it is now ignored.

This comment has been minimized.

@tathagatachowdhury

tathagatachowdhury Feb 25, 2019

Author Contributor

Acknowledged and updated code.

@fasaxc

fasaxc approved these changes Feb 25, 2019

@fasaxc fasaxc merged commit 33eebff into projectcalico:master Feb 25, 2019

2 checks passed

license/cla Contributor License Agreement is signed.
Details
semaphoreci The build passed on Semaphore.
Details

@caseydavenport caseydavenport added this to the Calico v3.6.0 milestone Feb 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.