Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contains/startswith/endswith selector operators. #1036

Merged
merged 1 commit into from Feb 25, 2019

Conversation

Projects
None yet
2 participants
@fasaxc
Copy link
Member

fasaxc commented Feb 21, 2019

Description

Add contains, starts with and ends with operators to selector syntax.

Todos

  • Tests
  • Documentation
  • Release note

Release Note

Selector syntax now supports operators for substring matching: "contains", "starts with" and "ends with".

@fasaxc fasaxc requested a review from neiljerram Feb 21, 2019

@fasaxc fasaxc force-pushed the fasaxc:add-contains branch from c315e21 to 924295f Feb 21, 2019

@neiljerram

This comment has been minimized.

Copy link
Member

neiljerram commented Feb 21, 2019

FYI there's also a release note on the draft doc PR that I raised at projectcalico/calico#2410. I think the release note here is good, so should probably delete the one at #2410, if #2410 is used at all.

@neiljerram
Copy link
Member

neiljerram left a comment

LGTM. Are you also going to a test for contains contains 'contains'?

@fasaxc fasaxc force-pushed the fasaxc:add-contains branch from 924295f to 960598b Feb 25, 2019

@fasaxc fasaxc added this to the Calico v3.6.0 milestone Feb 25, 2019

@fasaxc

This comment has been minimized.

Copy link
Member Author

fasaxc commented Feb 25, 2019

Looks like I hit an unrelated flake.

@fasaxc fasaxc merged commit 725f193 into projectcalico:master Feb 25, 2019

1 of 2 checks passed

semaphoreci The build failed on Semaphore.
Details
license/cla Contributor License Agreement is signed.
Details

@fasaxc fasaxc deleted the fasaxc:add-contains branch Feb 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.