Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datamodel for VXLAN encapsulation support #1065

Merged
merged 1 commit into from Apr 5, 2019

Conversation

Projects
None yet
3 participants
@caseydavenport
Copy link
Member

commented Mar 26, 2019

Description

Todos

  • Tests
  • Documentation
  • Release note

Release Note

VXLAN encapsulation can now be configured per IP pool
@fasaxc
Copy link
Member

left a comment

Looking good, maybe add a validator test, would catch typos or missing field tag?

Show resolved Hide resolved lib/apis/v3/node.go Outdated

@caseydavenport caseydavenport force-pushed the caseydavenport:vxlan-datamodel branch 2 times, most recently from 1b238d4 to 086e10c Mar 27, 2019

@caseydavenport caseydavenport force-pushed the caseydavenport:vxlan-datamodel branch from bb6b7ed to 947aaf6 Apr 4, 2019

@caseydavenport caseydavenport force-pushed the caseydavenport:vxlan-datamodel branch from 1cb7edf to 9083310 Apr 4, 2019

@caseydavenport

This comment has been minimized.

Copy link
Member Author

commented Apr 4, 2019

OK - I think this is good to go.

There is an outstanding question about whether we need an additional field for the node IP address that isn't a subfield of the BGP struct, since VXLAN requires the node IP but doesn't use BGP.

I think we can merge as-is though, and then deliberate on whether we want to do anything about that afterwards.

One option might to add a new top-level field and deprecate the BGP one, and then switching clients over to using the new field for both BGP and VXLAN, falling back on the BGP field if the top-level isn't present.

@fasaxc

fasaxc approved these changes Apr 5, 2019

@fasaxc fasaxc merged commit 1b15fa9 into projectcalico:master Apr 5, 2019

2 checks passed

license/cla Contributor License Agreement is signed.
Details
semaphoreci The build passed on Semaphore.
Details

@caseydavenport caseydavenport deleted the caseydavenport:vxlan-datamodel branch Apr 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.